Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] hwloc powerpc rhel5 and power7 patch
From: Samuel Thibault (samuel.thibault_at_[hidden])
Date: 2010-09-20 12:03:27

Alexey Kardashevskiy, le Thu 16 Sep 2010 14:10:08 +1000, a écrit :
> 1. What should I change in my patch to have it committed into the svn?
> Specifically:
> - where do I put IBM-specific code?

I think it's good enough as it is now, since it's just a particular case
of the generic devtree parsing code.

> - may be there is a better way to detect that no cache info was fetched
> from sysfs

It's not so bad. We'll probably have to rethink that kind of thing when
we move to loadable modules.

> - is the coding style ok? :-)