Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines
From: Bert Wesarg (bert.wesarg_at_[hidden])
Date: 2010-03-12 02:53:16

On Fri, Mar 12, 2010 at 08:45, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:
> I just fixed escaped characters and used your strsep loop for parsing
> options. I'll keep your patch on the side in case we find a solution
> that is compatible with fsroot. Thanks a lot.

Thank you.

Unfortunately, I discovered as small nitch in the strsep() loop,
because mount options can also be of the form <opt>=<value>. So if in
the future cpuset can have attributes, the loop will not catch this.