Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] [PATCH] Use getmntent_r(3) to parse /proc/mounts lines
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2010-03-12 02:45:30

Bert Wesarg wrote:
>> Ups, what about the fsroot_fd now? I think this has something to do if
>> /proc and /sys are not mounted at the root, for example in test mode,
>> right?
> I'm right. The only way out I see is to step aside from openat and use
> string operations to for this.
> I see that this would limit the test suit for debug builds, but I also
> don't see a need for a user to set the FSROOT in a production system
> either.

Yes, production systems can use a XML file if they really need a custom
topology. fsroot is only for debugging the Linux code.

I just fixed escaped characters and used your strsep loop for parsing
options. I'll keep your patch on the side in case we find a solution
that is compatible with fsroot. Thanks a lot.