Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] signed / unsigned
From: Samuel Thibault (samuel.thibault_at_[hidden])
Date: 2009-12-17 10:54:28

Jeff Squyres, le Thu 17 Dec 2009 07:51:34 -0500, a écrit :
> > > Re make check - I know it exists, but it was difficult to integrate the
> > > embedded test in with the existing "check" target because the embedded test
> > > effectively needs a full hwloc tarball to compile against.
> >
> > Ok, but you could also just run make check in the standalone version
> > already.
> Yes, and you still can (and it works). But it doesn't call the embedded test because of the reasons I mentioned. Note, too, that the "make check" in the top-level directory does not test embedded functionality; that's why I created a specific test for it.

Ok, sure. I just mean it could have been good to run make check before
commiting the signed/unsigned change.