Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r30860 - in trunk/ompi/mca: btl/usnic rte
From: Ralph Castain (rhc_at_[hidden])
Date: 2014-02-27 10:16:30

On Feb 27, 2014, at 6:58 AM, Jeff Squyres (jsquyres) <jsquyres_at_[hidden]> wrote:

> On Feb 27, 2014, at 3:33 AM, George Bosilca <bosilca_at_[hidden]> wrote:
>> I’m concerned about your usage of abort here. Looking at the code I noticed that you call RTE_ABORT deep inside the BTL stack. This is a significant divergence from our current behavior (except for USNIC apparently as the code is now in the 1.7). The BTLs are not deciders, but merely reporters. Any error should be reported upstream, and will be dealt with at that level.
> The majority of places we call abort in this commit is actually down in a progress thread. We didn't think it was safe to call the PML error function in a progress thread -- is that incorrect?

If not, then we probably should create some mechanism for doing so. I agree with George that we shouldn't call abort inside a library

> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to:
> _______________________________________________
> devel mailing list
> devel_at_[hidden]