Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [EXTERNAL] RFC: OMPI_FREE_LIST_{GET|WAIT} lose the rc argument
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-07-02 11:17:52


I submitted a patch like this a while ago, and it met violent resistance. :-) Although no one on the call today remembers exactly who raised the resistance...

On Jul 2, 2013, at 10:40 AM, "Barrett, Brian W" <bwbarre_at_[hidden]> wrote:

> On 7/2/13 8:22 AM, "George Bosilca" <bosilca_at_[hidden]> wrote:
>> Our macros for the OMPI-level free list had one extra argument, a possible return value to signal that the operation of retrieving the element from the free list failed. However in this case the returned pointer was set to NULL as well, so the error code was redundant. Moreover, this was a continuous source of warnings when the picky mode was on.
>> The attached parch remove the rc argument from the OMPI_FREE_LIST_GET and OMPI_FREE_LIST_WAIT macros, and change to check if the item is NULL instead of using the return code.
>> Deadline: July 4th
> Works for me.
> Brian
> --
> Brian W. Barrett
> Scalable System Software Group
> Sandia National Laboratories
> _______________________________________________
> devel mailing list
> devel_at_[hidden]

Jeff Squyres
For corporate legal information go to: