Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] PATCH: Wrong event_type value passed in to show_help when getting xrc async events
From: N.M. Maclaren (nmm1_at_[hidden])
Date: 2010-07-15 07:44:25

On Jul 15 2010, Jeff Squyres wrote:
>On Jul 15, 2010, at 2:14 AM, nadia.derbey wrote:
>> The only warning I'm getting in the part of the code impacted by the
>> patch is:
>> ---------------------
>> ../../../../../ompi/mca/btl/openib/btl_openib_async.c(322): warning
>> #188: enumerated type mixed with another type
>> event_type ^= IBV_XRC_QP_EVENT_FLAG;
>> ---------------------
>Ya, that's the one.
> Is there any way to get rid of that @!#@#$ warning? I'm not sure what
> it's complaining about -- event_type and IBV_XRC_QP_EVENT_FLAG are the
> same type, no?

Are you sure? I don't know where that is specified, but my guess is that
it's type isn't clearly specified and the header happens to use an enum.
Anyway, if that is so, there is a simple fix (not tested):

            event_type ^= (int)IBV_XRC_QP_EVENT_FLAG;

Most of the casts in my own code are to shut compilers up - not that I
think their warnings are bad, so much as the language and interfaces
specifications require their users to ignore best practice.

Nick Maclaren.