Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] r21096
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2009-04-29 10:35:28

On Apr 29, 2009, at 9:33 AM, Ralph Castain wrote:

>> My personal opinion however is, that every header and every source
>> file should
>> be self contained:
>> It should include all the headers with symbols it needs, no less, and
>> certainly not more ;-)
> That's an unusual coding style - we could debate the relative pros
> and cons of it for quite some time. Typically, if a body of code is
> going to all require the same headers, coding efficiency would put
> those dependencies in a common .h file, not explicitly copy/paste
> them into every individual file.

FWIW, this is the style that was used in the C bindings -- IIRC, those
three header files were #included via ompi/c/bindings.h explicitly so
that they would not need to be #included in every single .c file
(partly because there are so many .c files).

Hmm. :-\

Jeff Squyres
Cisco Systems