Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

From: Tim S. Woodall (twoodall_at_[hidden])
Date: 2005-09-21 08:53:31

Gleb Natapov wrote:
> Hello Galen,
> Finally I've got some time to look through the new code.
> I have couple of notes. In pml_ob1_rdma.c you try to merge
> registrations in the number of places. The code looks like this:
> btl_mpool->mpool_deregister(btl_mpool, reg);
> btl_mpool->mpool_register(btl_mpool,
> new_base,
> new_len,
> &reg);
> How do you know reg is not in use? You can't deregister it if somebody
> is using the registration!

Good catch... this should check the reference count and
only deregister when the reference count actually goes to zero...