Open MPI logo

Open MPI User's Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Open MPI User's mailing list

Subject: Re: [OMPI users] ierr vs ierror in F90 mpi module
From: W Spector (w6ws_at_[hidden])
Date: 2014-05-15 20:01:13


Hi Jeff and the list,

A year ago, we had the discussion appended below. I just downloaded
v1.8.1 and the F90 module is still very broken. And once again I am
having to modify my local version. (+1 for open source!) Will it be
fixed in v1.8.2?

Configure is using the "use-mpi-tkr" version on my system. I can see
that the "use-mpi-f08" version is much better.

Walter

On 04/26/2013 03:14 PM, Jeff Squyres (jsquyres) wrote:
> I committed that part; thanks.
>
> On Apr 26, 2013, at 5:51 PM, W Spector <w6ws_at_[hidden]> wrote:
>
>> Hi Jeff,
>>
>> To take care of the ierr->ierror conversion, simply do the following:
>>
>> cd openmpi-1.7.1/ompi/mpi/fortran/use-mpi-tkr/scripts
>> ls -1 *.sh | xargs -i -t ex -c ":1,\$s?ierr?ierror?" -c ":wq" {}
>>
>> Then go up a level to openmpi-1.7.1/ompi/mpi/fortran/use-mpi-tk and use:
>>
>> cd ..
>> ls -1 fort*.in | xargs -i -t ex -c ":1,\$s?ierr?ierror?" -c ":wq" {}
>>
>> Last, the use-mpi-ignore-tkr directory:
>>
>> cd ../use-mpi-ignore-tkr
>> ls -1 mpi*.in | xargs -i -t ex -c ":1,\$s?ierr?ierror?" -c ":wq" {}
>>
>> As you can tell from the below, I needed to use a few MPI_Type calls. So fixed the few that I needed in the openmpi-1.7.1/ompi/mpi/fortran/use-mpi-tkr/scripts directory. I didn't exhaustively go through and verify every interface in the whole MPI library.
>>
>> Walter
>>
>> On 04/26/2013 11:53 AM, Jeff Squyres (jsquyres) wrote:
>>> On Apr 25, 2013, at 10:52 PM, W Spector <w6ws_at_[hidden]> wrote:
>>> ...
>>>> I went into the openmpi-1.7.1/ompi/mpi/fortran/use-mpi-tkr/scripts directory and modified the files to use ierror instead of ierr. (One well-crafted line of shell script.) Did the same with a couple of .h.in files in the use-mpi-tkr and use-mpi-ignore-tkr directories, and use-mpi-tkr/attr_fn-f90-interfaces.h.in. (One editor command each.)
>>>>
>>>> With the above, the mpi module is in much better shape. However there are still some scattered incorrect non-ierror argument names. A few examples from the code I am working with:
>>>>
>>>> MPI_Type_create_struct: The 2nd argument should be "array_of_blocklengths", instead of "array_of_block_lengths"
>>>>
>>>> MPI_Type_commit: "datatype" instead of "type"
>>>>
>>>> MPI_Type_free: Again, "datatype" instead of "type"
>>>>
>>>> There are more...
>>>
>>> Cool. Any chance you could send us a patch?
>>>
>> _______________________________________________
>> users mailing list
>> users_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/users
>
>