On Aug 15, 2008, at 1:50 PM, Bert Wesarg wrote:
> Its better to handle the default values, so that the code don't need
> to changed again if powerpc is up-to-date.
Just to make sure I understand -- you're saying that if we read <0
from phsyical_package_id, we should treat it as a non-fatal error
(i.e., ignore that processor), right?
Come to think of it, I can't imagine a system with both an AMD/Intel
processor *and* a POWER processor, so we could probably dump out of
the loop at the first <0 physical_package_id (or any error) and assume
that topology isn't supported at all.
But I guess the cost is extremely low, and this isn't performance
critical code, so having it check all the processors anyway is a safe
thing to do (in case some machine someday *does* contain heterogeneous
chips, all running Linux, which, with the advent of accelerators, I
guess isn't *too* far fetched...). PLPA *almost* does this today, but
could probably be a bit better about error checking.
--
Jeff Squyres
Cisco Systems
|
![[Flag]](../../../../../community/mirrors/flag-us.gif){kind=small}