PLPA Users' Mailing List Archives

Subject: Re: [PLPA users] svn:plpa r155
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2008-03-12 18:48:17

• Next message: Brian Curtis: "[PLPA users] Patch to remove verbose if-else"
• Previous message: Bert Wesarg: "Re: [PLPA users] svn:plpa r155"
• In reply to: Bert Wesarg: "Re: [PLPA users] svn:plpa r155"

...and sometimes coding during a meeting is not always a good idea. :-)

Thanks - fixed in r161. This little wigglet didn't make rc1, and
probably isn't worth an rc2.

On Mar 12, 2008, at 12:20 PM, Bert Wesarg wrote:

> On Wed, Mar 12, 2008 at 3:40 PM, <jsquyres_at_[hidden]> wrote:
>> Author: jsquyres
>> Date: 2008-03-12 10:40:58 EDT (Wed, 12 Mar 2008)
>> New Revision: 155
>> URL: https://svn.open-mpi.org/trac/plpa/changeset/155
>>
>> Log:
>> Protect the use of the environment variable PLPA_SYSFS_MOUNT with the
>> --enable-debug configure switch. --enable-debug is enabled
>> automatically if configure sees a .svn directory (but of course can
>> be
>> enabled or disabled with --enable/disable--debug, regardless of
>> whether .svn is there or not).
> Thanks, but...
>
>> Modified: trunk/src/libplpa/plpa_map.c
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- trunk/src/libplpa/plpa_map.c (original)
>> +++ trunk/src/libplpa/plpa_map.c 2008-03-12 10:40:58 EDT
>> (Wed, 12 Mar 2008)
>> @@ -394,10 +394,12 @@
>> const char *sysfs_mount = "/sys";
>> char *temp;
> ...this should be inside the #if, to prevent compiler warnings.
>
>>
>> +#if PLPA_DEBUG
>> temp = getenv("PLPA_SYSFS_MOUNT");
>> if (temp) {
>> sysfs_mount = temp;
>> }
>> +#endif
>>
>> load_cache(sysfs_mount);
>> return 0;
>
> Bye
> Bert
> _______________________________________________
> plpa-users mailing list
> plpa-users_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/plpa-users

-- 
Jeff Squyres
Cisco Systems

• Next message: Brian Curtis: "[PLPA users] Patch to remove verbose if-else"
• Previous message: Bert Wesarg: "Re: [PLPA users] svn:plpa r155"
• In reply to: Bert Wesarg: "Re: [PLPA users] svn:plpa r155"