Brian replied off-list, I think because he was too polite:
1. He said right in the subject that he's using v1.1
2. I totally mis-read his patch
Oops. I blame jet lag. :-)
I dug a bit deeper because the suggested patch "fixed" the problem,
but had the side-effect of making the PLPA_STANDALONE macro not really
set "standalone" mode at all.
The real issue is that PLPA's top-level configure calls
PLPA_STANDALONE, and PLPA_STANDALONE was AC_REQUIRE'ing
_PLPA_INTERNAL_SETUP, which checked all the command line switches
(this is where --enable-included-mode was detected and set). But then
the body of PLPA_STANDALONE would fire and reset it back to standalone
mode. Doh!
So a better solution is to remove PLPA_STANDALONE from the top-level
configure.ac and just let that that be the default. Doing this,
however, revealed another bug / undocumented / unintended behavior in
included mode: you had to call one of a few macros *before* you call
PLPA_INIT in order to set the prefix path for what files plpa.m4 would
AC_OUTPUT. So I did the following:
- created a new PLPA_INIT that takes a 3rd parameter: the prefix where
AC_OUTPUT to should generate its files
- deprecated the 2-parameter form of PLPA_INIT
- deprecated an undocumented parameter to PLPA_INCLUDED
I committed all this to the SVN trunk and updated the README
accordingly.
Brian -- could you give this a whirl and let me know if it works for
you?
On Mar 9, 2008, at 5:39 PM, Jeff Squyres wrote:
> Thanks!
>
> What version of PLPA are you using? This fix already seems to already
> be in PLPA v1.1 (and many others -- I used Open MPI as a prototype for
> "included mode" and fixed many bugs that way).
>
>
> On Mar 8, 2008, at 1:32 AM, Brian Curtis wrote:
>
>> Here is a patch for the previously reported --enable-included-mode
>> defect:
>>
>> --- config/plpa.m4 2008-03-08 02:06:42.000000000 -0500
>> +++ config/plpa.m4 2008-03-08 02:31:34.000000000 -0500
>> @@ -102,7 +102,6 @@ int i = 1;],
>> AC_DEFUN([PLPA_STANDALONE],[
>> m4_define([plpa_config_prefix],[.])
>> AC_REQUIRE([_PLPA_INTERNAL_SETUP])
>> - plpa_mode=standalone
>> ])dnl
>>
>>
>> #-----------------------------------------------------------------------
>>
>>
>>
>> Brian
>>
>> On Mar 8, 2008, at 1:28 AM, Brian Curtis wrote:
>>
>>> The --enable-included-mode option to configure is a no-op. The
>>> mode is always standalone.
>>>
>>>
>>> Brian
>>
>> _______________________________________________
>> plpa-users mailing list
>> plpa-users_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/plpa-users
>
>
> --
> Jeff Squyres
> Cisco Systems
>
> _______________________________________________
> plpa-users mailing list
> plpa-users_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/plpa-users
--
Jeff Squyres
Cisco Systems
|
![[Flag]](../../../../../community/mirrors/flag-us.gif){kind=small}