Excellent; I missed this case when I did PLPA v1.1 for Open MPI
because OMPI used the embedded m4 macro PLPA_INCLUDED (vs. --enable-
included-mode). Thanks!
I slightly amended your patch to check to for and allow the case when
someone uses --enable-included-module and --enable-executables (just
in the off-chance that someone may want to do that...).
I committed your patch and have slated it for v1.1.1.
Currently, this is the only patch after v1.1 -- do you have a need for
this in a release, or would you mind waiting a little bit to see if
anything else shows up? (and pending resolution of your other issue -
I'll reply on that thread)
Also, I'm curious: are you putting PLPA in MVAPICH[2]? I took a quick
troll through the MVAPICH svn logs and didn't see it listed anywhere.
On Mar 8, 2008, at 1:59 AM, Brian Curtis wrote:
> The plpa documentation states that --enables-included-mode will not
> build executables, but in practice, the option does not disable
> executables. The patch below corrects this defect by giving --enable-
> included-mode precedence over enabling of executables.
>
>
> Brian
>
>
> --- config/my_plpa.m4 2008-03-08 02:44:06.000000000 -0500
> +++ config/plpa.m4 2008-03-08 02:50:38.000000000 -0500
> @@ -162,12 +162,23 @@ AC_DEFUN([_PLPA_INTERNAL_SETUP],[
> plpa_emulate=no
> fi
>
> + # Build and install the executables or no?
> + AC_ARG_ENABLE([executables],
> + AC_HELP_STRING([--disable-executables],
> + [Using --disable-executables
> disables building and installing the PLPA executables]))
> + if test "$enable_executables" = "yes" -o "$enable_executables" =
> ""; then
> + plpa_executables=yes
> + else
> + plpa_executables=no
> + fi
> +
> # Included mode, or standalone?
> AC_ARG_ENABLE([included-mode],
> AC_HELP_STRING([--enable-included-mode],
> [Using --enable-included-mode
> puts the PLPA into "included" mode. The default is --disable-
> included-mode, meaning that the PLPA is in "standalone" mode.]))
> if test "$enable_included_mode" = "yes"; then
> plpa_mode=included
> + plpa_executables=no
> else
> plpa_mode=standalone
> fi
> @@ -183,16 +194,6 @@ dnl else
> dnl plpa_fortran=no
> dnl fi
>
> - # Build and install the executables or no?
> - AC_ARG_ENABLE([executables],
> - AC_HELP_STRING([--disable-executables],
> - [Using --disable-executables
> disables building and installing the PLPA executables]))
> - if test "$enable_executables" = "yes" -o "$enable_executables" =
> ""; then
> - plpa_executables=yes
> - else
> - plpa_executables=no
> - fi
> -
> # Change the symbol prefix?
> AC_ARG_WITH([plpa-symbol-prefix],
> AC_HELP_STRING([--with-plpa-symbol-prefix=STRING],
> _______________________________________________
> plpa-users mailing list
> plpa-users_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/plpa-users
--
Jeff Squyres
Cisco Systems
|
![[Flag]](../../../../../community/mirrors/flag-us.gif){kind=small}