Open MPI logo

MTT Devel Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all MTT Devel mailing list

Subject: [MTT devel] fix zombie commit
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-02-24 06:09:45


Mike --

Please protect this code better; MTT is also run on Solaris and OS X.

Also, can you describe more fully the case where zombies are being left behind by MTT?

On Feb 24, 2013, at 1:44 AM, <svn-commit-mailer_at_[hidden]> wrote:

> Author: miked (Mike Dubman)
> Date: 2013-02-24 01:44:31 EST (Sun, 24 Feb 2013)
> New Revision: 1589
> URL: https://svn.open-mpi.org/trac/mtt/changeset/1589
>
> Log:
> * fix: fork leaves zombie processes sometimes. temp fix: detect zombie and proceed with tests.
>
> Text files modified:
> trunk/lib/MTT/DoCommand.pm | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> Modified: trunk/lib/MTT/DoCommand.pm
> ==============================================================================
> --- trunk/lib/MTT/DoCommand.pm Wed Feb 20 12:41:12 2013 (r1588)
> +++ trunk/lib/MTT/DoCommand.pm 2013-02-24 01:44:31 EST (Sun, 24 Feb 2013) (r1589)
> @@ -641,6 +641,12 @@
> if (!$pid_exists) {
> Verbose("--> Process completed somehow at " . time() . ", proceeding with tests\n");
> $resume_tests++;
> + } else {
> + my $matches = MTT::Files::Grep("zombie", "/proc/$pid/status");
> + if (@$matches) {
> + Verbose("--> Process become Zombie at " . time() . ", proceeding with tests\n");
> + $resume_tests++;
> + }
> }
> # Remove the timeout sentinel file, if a timeout notify timeout value is set
> if (defined($end_time) and time() > $end_time) {
> _______________________________________________
> mtt-svn mailing list
> mtt-svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-svn

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/