Open MPI logo

MTT Devel Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all MTT Devel mailing list

Subject: Re: [MTT devel] MTToGDS
From: Igor Ivanov (igor.ivanov_at_[hidden])
Date: 2010-02-10 08:39:13


Yes, it is more friendly way.

Jeff Squyres wrote:
On Feb 10, 2010, at 4:18 AM, Igor Ivanov wrote:

  
I believe that it is just a warning and you can use mtt w/o analyzer that allow get additional info from output.
    

True, it's just a warning.  But it's (very) big and ugly.  :-)  Makes it quite difficult to read --verbose output and see if anything actually went wrong.

Is this patch correct?  It checks to see if there is no analyze_module, and if so, just returns the form.


Index: lib/MTT/Reporter/MTTGDS.pm
===================================================================
--- lib/MTT/Reporter/MTTGDS.pm  (revision 1346)
+++ lib/MTT/Reporter/MTTGDS.pm  (working copy)
@@ -576,6 +576,11 @@
 
     my $ini    = $MTT::Globals::Internals->{ini};
     my $module = $ini->val( "Test run: " . $section, "analyze_module" );
+
+    # If there's no analyze module, then just return
+    return $form
+        if (!$module);
+
     $module = "MTT::Test::Analyze::Performance::$module";
     my $method = "PreReport";
     my @args   = ( $phase, $section, $report );


  


__________ Information from ESET NOD32 Antivirus, version of virus signature database 4854 (20100210) __________

The message was checked by ESET NOD32 Antivirus.

http://www.esetnod32.ru