Open MPI logo

MTT Devel Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all MTT Devel mailing list

Subject: Re: [MTT devel] [MTT svn] svn:mtt-svn r1164
From: Ethan Mallove (ethan.mallove_at_[hidden])
Date: 2008-03-20 12:19:11


I sense this "do_not_run" stuff could be useful to me, but
I'm not sure. Can you give a simple use case for
"do_not_run"? Could "do_not_run" be achieved by just
commenting out the INI lines that pertain to a certain
group? E.g., do these "#" comments ...

  # simple_really_slow:tests = src/MPI_Isend_flood_c src/MPI_Send_flood_c
  # simple_really_slow:pass = &and(&test_wifexited(), &eq(&test_wexitstatus(), 0))
  # simple_really_slow:exclusive = 1
  # simple_really_slow:timeout = &sum(90, &multiply(3, &test_np()))

... have the same effect as this?

  simple_really_slow:do_not_run = 1

-Ethan

On Thu, Mar/20/2008 10:03:50AM, jsquyres_at_[hidden] wrote:
> Author: jsquyres
> Date: 2008-03-20 10:03:50 EDT (Thu, 20 Mar 2008)
> New Revision: 1164
> URL: https://svn.open-mpi.org/trac/mtt/changeset/1164
>
> Log:
> Added parameter to Simple specify module: do_not_run. If set to 1 for
> a specific subsection (and the subsection is exclusive), then those
> tests will not be run. Handy for explicitly specifying tests that
> exist by should ''not'' be run.
>
> Text files modified:
> trunk/CHANGES | 12 +++++++++---
> trunk/lib/MTT/Test/Specify/Simple.pm | 14 ++++++++++++++
> 2 files changed, 23 insertions(+), 3 deletions(-)
>
> Modified: trunk/CHANGES
> ==============================================================================
> --- trunk/CHANGES (original)
> +++ trunk/CHANGES 2008-03-20 10:03:50 EDT (Thu, 20 Mar 2008)
> @@ -168,7 +168,13 @@
> - before_make_install
> - after_make_install
>
> -- include_file(s) INI parameter - just like pre-processor "#include" directives
> +- include_file(s) INI parameter - just like pre-processor "#include"
> + directives
>
> -- trivial_tests_languages - comma separated list of languages to use for trivial
> - tests (default: "c,c++,f77,f90").
> +- trivial_tests_languages - comma separated list of languages to use
> + for trivial tests (default: "c,c++,f77,f90").
> +
> +- added parameter to Simple specify module: do_not_run. If set to 1
> + for a specific subsection (and the subsection is exclusive), then
> + those tests will not be run. Handy for explicitly specifying tests
> + that exist but should *not* be run.
>
> Modified: trunk/lib/MTT/Test/Specify/Simple.pm
> ==============================================================================
> --- trunk/lib/MTT/Test/Specify/Simple.pm (original)
> +++ trunk/lib/MTT/Test/Specify/Simple.pm 2008-03-20 10:03:50 EDT (Thu, 20 Mar 2008)
> @@ -62,6 +62,7 @@
> # Now go through and see if any of the tests are marked as
> # "exclusive". If they are, remove those tests from all other
> # groups.
> + my @groups_to_delete;
> foreach my $group (keys %$params) {
> # If this group is marked as exclusive, remove each of its
> # tests from all other groups
> @@ -85,6 +86,19 @@
> }
> }
> }
> +
> + # After we've performed the exclusivity filter, if the tests
> + # are marked as "do_not_run", then delete this group (it's a
> + # way of specifying tests to *not* run). Don't delete them
> + # now, it may (will?) screw up the outter loop's "foreach".
> + if ($params->{$group}->{do_not_run}) {
> + push(@groups_to_delete, $group);
> + }
> + }
> +
> + # Delete all the groups that were marked
> + foreach my $t (@groups_to_delete) {
> + delete $params->{$t};
> }
>
> # Now go through those groups and make the final list of tests to pass
> _______________________________________________
> mtt-svn mailing list
> mtt-svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/mtt-svn