I see you added some casts, too. ;)

Re make check - I know it exists, but it was difficult to integrate the embedded test in with the existing "check" target because the embedded test effectively needs a full hwloc tarball to compile against. I played with making a sym link from tests/embedded to ../.. And using that as the test's "tarball", but that runs into problems when you run the test's autogen because it re autogens the entire tree (not just the embedded test).
So at least for the moment, it is a separate, manual test.

-jms
Sent from my PDA.  No type good.

----- Original Message -----
From: hwloc-devel-bounces@open-mpi.org <hwloc-devel-bounces@open-mpi.org>
To: Hardware locality development list <hwloc-devel@open-mpi.org>
Sent: Thu Dec 17 04:57:19 2009
Subject: Re: [hwloc-devel] signed / unsigned

Jeff Squyres, le Wed 16 Dec 2009 21:51:38 -0500, a écrit :
> On Dec 16, 2009, at 9:03 PM, Jeff Squyres wrote:
> > Ok, done.  Please review:
> >
> >    https://svn.open-mpi.org/trac/hwloc/changeset/1475
>
> I definitely broke something.  :-(

I've fixed everything.  Please note that these gcc warnings are not for
the developper to add casts everywhere.  Doing so either adds bugs or
hides bugs. Here there were both cases.

> >From my embedding test, I make a trivial app that does the following:

Please note that make check exists.

Samuel
_______________________________________________
hwloc-devel mailing list
hwloc-devel@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel