Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |  

This web mail archive is frozen.

This page is part of a frozen web archive of this mailing list.

You can still navigate around this archive, but know that no new mails have been added to it since July of 2016.

Click here to be taken to the new web archives of this list; it includes all the mails that are in this frozen archive plus all new mails that have been sent to the list since it was migrated to the new archives.

Subject: Re: [hwloc-devel] Use of <malloc.h>
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2014-01-10 12:26:23


Sweet; thanks.

On Jan 10, 2014, at 12:25 PM, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:

> Looks like we're good.
> Brice
>
>
>
> Le 10/01/2014 18:05, Jeff Squyres (jsquyres) a écrit :
>> K, will do.
>>
>> On Jan 10, 2014, at 12:00 PM, Brice Goglin <brice.goglin_at_[hidden]>
>> wrote:
>>
>>> Push it to master, we'll what regression testing at https://ci.inria.fr/hwloc/job/master-1-check/ thinks about it
>>> Brice
>>>
>>>
>>>
>>> "Jeff Squyres (jsquyres)" <jsquyres_at_[hidden]> a écrit :
>>> Brice / Samuel --
>>>
>>> In http://www.open-mpi.org/community/lists/devel/2014/01/13619.php, Paul Hargrove found this compiler warning:
>>>
>>> -----
>>> On OpenBSD the header malloc.h exists, but is NOT intended to be used:
>>> -bash-4.2$ grep -B2 'is obsolete' make.log
>>> CC bind.lo
>>> In file included from /home/phargrov/OMPI/openmpi-1.7-latest-openbsd5-amd64/openmpi-1.7.4rc2r30168/opal/mca/hwloc/hwloc172/hwloc/src/bind.c:17:
>>> /usr/include/malloc.h:4:2: warning: #warning "<malloc.h> is obsolete, use <stdlib.h>"
>>> -----
>>>
>>> What do you think of this patch (or something like it)?
>>>
>>> diff --git a/src/bind.c b/src/bind.c
>>> index 046b7cf..37921bc 100644
>>> --- a/src/bind.c
>>> +++ b/src/bind.c
>>> @@ -13,8 +13,9 @@
>>> #ifdef HAVE_SYS_MMAN_H
>>> # include <sys/mman.h>
>>> #endif
>>> -#ifdef HAVE_MALLOC_H
>>> -
>>> #
>>> include <malloc.h>
>>>
>>> +/* <malloc.h> is only needed if we don't have posix_memalign() */
>>> +#if defined(hwloc_getpagesize) && !defined(HAVE_POSIX_MEMALIGN) && defined(HAVE_MEMALIGN) && defined(HAVE_MALLOC_H)
>>> +#include <malloc.h>
>>> #endif
>>> #ifdef HAVE_UNISTD_H
>>> #include <unistd.h>
>>>
>>> _______________________________________________
>>> hwloc-devel mailing list
>>> hwloc-devel_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
>>
>
> _______________________________________________
> hwloc-devel mailing list
> hwloc-devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/