Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: [hwloc-devel] hwloc-1.8 patch
From: Pavan Balaji (balaji_at_[hidden])
Date: 2013-12-05 18:34:24


Hello,

Would you consider the following patch for hwloc-1.8 that we embed in the mpich version of hwloc? The commit log has the description. Please ignore the extra white-space piece of the commit.

----8<----
% git show 59cbc846 tests/embedded/configure.ac
commit 59cbc846d56eb259f6014b23114eed67b90abe95
Author: Rob Latham <robl_at_[hidden]>
Date: Thu Jun 27 19:07:36 2013 +0000

    automake subdir-object mode needs check for -c -o
    
    Older automake versions (at least 1.13.1) will complain if we asked for subdir
    mode and we did not verify that both -c and -o flags work (AM_PROG_CC_C_O)

diff --git a/src/pm/hydra/tools/topo/hwloc/hwloc/tests/embedded/configure.ac b/src/pm/hydra/tools/topo/hwloc/hwloc/tests/embedded/configure.ac
index d697e58d..c0d6ba17 100644
--- a/src/pm/hydra/tools/topo/hwloc/hwloc/tests/embedded/configure.ac
+++ b/src/pm/hydra/tools/topo/hwloc/hwloc/tests/embedded/configure.ac
@@ -9,9 +9,11 @@ AC_CANONICAL_TARGET
 AM_INIT_AUTOMAKE([1.10 dist-bzip2 foreign subdir-objects tar-ustar -Wall -Werror])
 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 
+
 AC_LANG([C])
 
 AC_PROG_CC
+AM_PROG_CC_C_O
 
 cat <<EOF
----8<----

  — Pavan

--
Pavan Balaji
http://www.mcs.anl.gov/~balaji