Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] [hwloc-svn] svn:hwloc r5606 - trunk
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2013-05-09 09:21:49


It was already fixed by the revert, sorry I forgot to make that clear.

We only use C++ to build a *C* file with g++. We don't have actual C++
code. Looks like CXX gets initialized properly, even when I comment out
our AC_PROC_CXX in configure.ac and the following code in hwloc_internal.m4:

    AC_MSG_CHECKING(if CXX works)
    AC_LANG_PUSH([C++])
    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
#include <iostream>
using namespace std;
int foo(void) {
  cout << "test" << endl;
  return 0;
}
        ]])], [hwloc_have_cxx=yes], [hwloc_have_cxx=no])
    AC_LANG_POP([C++])
    AC_MSG_RESULT([$hwloc_have_cxx])

If we remove the above and use LT_LANG(C++), what do you use instead of
"if HWLOC_HAVE_CXX" in doc/Makefile.am

Brice

Le 09/05/2013 14:57, Jeff Squyres (jsquyres) a écrit :
> Does this patch fix it? It's not clear to me from the LT docs whether you're supposed to call LT_LANG multiple times or LT_LANG with multiple languages, but this patch below seems to run the libtool C++ configury:
>
> Index: configure.ac
> ===================================================================
> --- configure.ac (revision 5609)
> +++ configure.ac (working copy)
> @@ -168,6 +168,7 @@
> AM_DISABLE_STATIC
> AM_PROG_LIBTOOL([dlopen win32-dll])
> LT_LANG([C])
> +LT_LANG([C++])
> LT_CONFIG_LTDL_DIR([src/libltdl])
> LTDL_INIT([recursive convenience])
> AC_CONFIG_FILES([src/libltdl/Makefile])
>
> (I couldn't generate the make check failure on my Mac with or without the additional LT_LANG, so I can't confirm if this is the correct fix or not)
>
>
> On May 8, 2013, at 2:28 AM, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:
>
>> We actually used C++ during make check (we test the C++ build of
>> doc/hwloc-hello.c)
>> (got a build failure report from https://ci.inria.fr/hwloc/)
>>
>> Brice
>>
>>
>>
>> Le 08/05/2013 02:27, svn-commit-mailer_at_[hidden] a écrit :
>>> Author: jsquyres (Jeff Squyres)
>>> Date: 2013-05-07 20:27:25 EDT (Tue, 07 May 2013)
>>> New Revision: 5606
>>> URL: https://svn.open-mpi.org/trac/hwloc/changeset/5606
>>>
>>> Log:
>>> Revert r5604 -- it's redundant with LT_LANG([C]).
>>>
>>> Text files modified:
>>> trunk/configure.ac | 4 ----
>>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>>
>>> Modified: trunk/configure.ac
>>> ==============================================================================
>>> --- trunk/configure.ac Tue May 7 20:18:05 2013 (r5605)
>>> +++ trunk/configure.ac 2013-05-07 20:27:25 EDT (Tue, 07 May 2013) (r5606)
>>> @@ -166,10 +166,6 @@
>>> # Compiler support -- we don't need that stuff.
>>> AM_ENABLE_SHARED
>>> AM_DISABLE_STATIC
>>> -# Tell libtool that we don't need Fortran or C++ support.
>>> -FC=no
>>> -F77=no
>>> -CXX=no
>>> AM_PROG_LIBTOOL([dlopen win32-dll])
>>> LT_LANG([C])
>>> LT_CONFIG_LTDL_DIR([src/libltdl])
>>> _______________________________________________
>>> hwloc-svn mailing list
>>> hwloc-svn_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn
>> _______________________________________________
>> hwloc-devel mailing list
>> hwloc-devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
>