Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] hwloc embedding vs libltdl
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-05-07 20:14:40


On May 7, 2013, at 6:25 PM, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:

>> - ensure to have libtool avoid setting up Fortran and C++ (a trick we learned from MPICH :-) )
>
> Is this related to ltdl anyhow?

No. Just picked it up since it's related to libtool. :-) It could well be a separate commit (and doesn't necessarily need to be back-ported everywhere).

>> - disallow embedded mode and plugins (per our phone discussion the other day)
>> - reorder the plugins support AC_MSG_RESULT to come before any WARN/ERROR messages
>
> I fixed 3 things in your patch (new version attached).
> * typo in comment
> * typo in SUBDIRS (HWLOC_LIBLTDL_SUBDIR vs HWLOC_LTDL_SUBDIR)
> * moved back that SUBDIRS= line into if PLUGINS so that we don't build
> ltdl when plugins is disabled
> Aside from these, that looks good to me.

Cool; I'll commit. Thanks!

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/