Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] Fwd: [hwloc-svn] svn:hwloc r5588 - trunk/config
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2013-05-07 02:48:32


I can't be 100% sure but the fix looks sane to me, and it didn't break
any regression testing build.

Brice

Le 07/05/2013 03:22, Jeff Squyres (jsquyres) a écrit :
> Brice / Samuel --
>
> Can you confirm that this is the correct fix? I need someone to review it so that I can CMR it into OMPI release branches.
>
> Thanks!
>
>
> Begin forwarded message:
>
>> From: <svn-commit-mailer_at_[hidden]>
>> Subject: [hwloc-svn] svn:hwloc r5588 - trunk/config
>> Date: May 6, 2013 9:16:45 PM EDT
>> To: <hwloc-svn_at_[hidden]>
>> Reply-To: <hwloc-devel_at_[hidden]>
>>
>> Author: jsquyres (Jeff Squyres)
>> Date: 2013-05-06 21:16:45 EDT (Mon, 06 May 2013)
>> New Revision: 5588
>> URL: https://svn.open-mpi.org/trac/hwloc/changeset/5588
>>
>> Log:
>> Per http://www.open-mpi.org/community/lists/users/2013/05/21850.php,
>> this -L should not be there: it adds an extra -L to the build
>> directory into the dependecy_libs in the generated .la file.
>>
>> Thanks to Stefan Friedel for identifying the problem.
>>
>> Text files modified:
>> trunk/config/hwloc.m4 | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> Modified: trunk/config/hwloc.m4
>> ==============================================================================
>> --- trunk/config/hwloc.m4 Mon May 6 08:47:19 2013 (r5587)
>> +++ trunk/config/hwloc.m4 2013-05-06 21:16:45 EDT (Mon, 06 May 2013) (r5588)
>> @@ -9,7 +9,7 @@
>> dnl All rights reserved.
>> dnl Copyright (c) 2004-2008 High Performance Computing Center Stuttgart,
>> dnl University of Stuttgart. All rights reserved.
>> -dnl Copyright © 2006-2011 Cisco Systems, Inc. All rights reserved.
>> +dnl Copyright © 2006-2013 Cisco Systems, Inc. All rights reserved.
>> dnl Copyright © 2012 Blue Brain Project, BBP/EPFL. All rights reserved.
>> dnl Copyright © 2012 Oracle and/or its affiliates. All rights reserved.
>> dnl See COPYING in top-level directory.
>> @@ -1078,7 +1078,6 @@
>> AC_SUBST(HWLOC_CFLAGS)
>> HWLOC_CPPFLAGS='-I$(HWLOC_top_builddir)/include -I$(HWLOC_top_srcdir)/include'
>> AC_SUBST(HWLOC_CPPFLAGS)
>> - HWLOC_LDFLAGS='-L$(HWLOC_top_builddir)/src'
>> AC_SUBST(HWLOC_LDFLAGS)
>> AC_SUBST(HWLOC_LIBS)
>> AC_SUBST(HWLOC_LIBS_PRIVATE)
>> _______________________________________________
>> hwloc-svn mailing list
>> hwloc-svn_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn
>