Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] Solaris chiptype / rename.h
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2013-03-26 12:15:07


K; I'll commit on the trunk. Thanks.

On Mar 26, 2013, at 12:10 PM, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:

> Indeed the problem is not reported by my custom check in tests/rename/
> because it includes hwloc.h before solaris-chiptype.h. So your
> conclusion looks ok to me.
>
> Brice
>
>
>
> Le 26/03/2013 16:56, Jeff Squyres (jsquyres) a écrit :
>> Brice --
>>
>> I just committed https://svn.open-mpi.org/trac/hwloc/changeset/5513 on the v1.5 branch, which ensures that the symbols in topology-solaris-chiptype.c are subject to <hwloc/rename.h>. We discovered this problem on the OMPI SVN trunk, which embeds hwloc 1.5.2.
>>
>> On the hwloc trunk, I see that #include <hwloc/autogen/config.h> was added to chiptype.c.
>>
>> Just to be sure before I commit (and because I don't have a Solaris machine with which to test), this will *not* include <hwloc/rename.h>, and therefore merging over r5513 to the trunk is still a good idea (i.e., include <hwloc.h>).
>>
>> Is that right?
>>
>
> _______________________________________________
> hwloc-devel mailing list
> hwloc-devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/