Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] libpci: GPL
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2013-02-06 16:25:09


Le 06/02/2013 19:01, Brice Goglin a écrit :
> Le 06/02/2013 16:10, Jeff Squyres (jsquyres) a écrit :
>> On Feb 6, 2013, at 7:02 AM, Brice Goglin <Brice.Goglin_at_[hidden]> wrote:
>>
>>> Just pushed Samuel's patch + the configury + one fix for object names.
>>> The code currently uses libpciaccess by default. pciutils is only used
>>> when libpciaccess isn't available.
>> I think that this will still result in many GPL-enabled hwlocs by default because libpci is installed on many distros by default, but libpciaccess is not.
>>
>> How about:
>>
>> - Check for libpciaccess. If found, use it. STOP.
>> - If not found:
>> - check for libpci.
>> - if found, and if --enable-gpl-taint was specified, use it. STOP.
>> - if not found, display the usual "no pci support" message at the end. STOP.
>> - if found:
>> - display the usual "no pci support" message at the end
>> - but also display a big, bold, flashing message saying "We can enable PCI support in one of two ways: 1) download/install libpciaccess (http://cgit.freedesktop.org/xorg/lib/libpciaccess/), or 2) pass --enable-gpl-taint to allow hwloc to use libpci, BUT BE AWARE THAT THIS MAKES THIS HWLOC BINARY AND EVERYTHING THAT IT LINKS TO BE GPL!"
> If "configure --help" and the big warning both say that enabling it
> *may* taint as GPL, the option could just be "--enable-libpci".
>

See the attached patch.

By the way, libpciaccess looks OK in a FreeBSD 9.1 VM. On NetBSD 6, the
only problem I see is that it doesn't find vendor/device names, but I am
far from being sure I have everything needed installed.

Brice