Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] -lpicl on Solaris
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2012-06-12 10:30:17


Cool, we'll do that, then. I'll commit it to OMPI and to hwloc.

...and still remember that Terry is the root of all evil. Got it.

;-)

On Jun 12, 2012, at 10:28 AM, Brice Goglin wrote:

> The current -lpicl in src/Makefile.am comes from Terry's initial Solaris CPUModel detection patch. If Terry is ok, I am fine with your change as well.
>
> Brice
>
>
>
> Le 12/06/2012 16:19, Jeff Squyres a écrit :
>> I recently upgraded OMPI's SVN trunk to hwloc 1.4.2, and immediately broke builds on Solaris. After some hunting around, here's what our friends at Oracle have found:
>>
>> - Building hwloc 1.4.2 standalone on Solaris works fine.
>> - Building OMPI SVN trunk (with hwloc 1.4.2 embedded) on Solaris fails due to a missing -lpicl.
>> - The issue seems to be in hwloc's src/Makefile.am:
>>
>> if HWLOC_HAVE_SOLARIS
>> ldflags += -lpicl
>> endif HWLOC_HAVE_SOLARIS
>>
>> Specifically, -lpicl gets added to standalone builds but not embedded builds.
>>
>> Shouldn't the check for -lpicl be in hwloc.m4 so that it gets added to HWLOC_EMBEDDED_LIBS? See the attached patch.
>>
>> Or is there a deeper reason we didn't use AC_CHECK_LIB and used HWLOC_HAVE_SOLARIS instead? (e.g., is -lpicl Bad on other platforms?)
>>
>>
>>
>>
>> _______________________________________________
>> hwloc-devel mailing list
>>
>> hwloc-devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
>
> _______________________________________________
> hwloc-devel mailing list
> hwloc-devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/