Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] MPICH2 patches for hwloc
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2012-05-11 14:44:33


(3) is of course OK, and (2) should be OK too, so I'll apply them to
v1.4 and trunk.
(1) is for Jeff.

Brice

Le 11/05/2012 20:35, Pavan Balaji a écrit :
> Hi all,
>
> We just upgraded to hwloc-1.4.2. We'd like to push upstream some
> patches that we maintain, if you find them appropriate.
>
> Here's what we currently maintain:
> https://trac.mcs.anl.gov/projects/mpich2/changeset/9851
>
> There are three pieces in this patch that we want to point out:
>
> 1. The patch to Makefile.am is an ugly hack to get "make dist" working
> in hydra. Specifically, autogen.sh was having trouble running in the
> tarball created by "make dist", since it still expects the utils,
> tests, and doc directories to be available, but they are never
> included in the embedded builds. This is definitely *not* something
> you should include upstream, so please only consider this as a bug
> report instead. What are other packages using hwloc in embedded mode
> doing?
>
> 2. Within config/hwloc.m4, we moved AC_USE_SYSTEM_EXTENSIONS above as
> AC_REQUIRE(AC_USE_SYSTEM_EXTENSIONS). This is cleaner for the cases
> where a higher-level configure (for embedded builds) does an
> AC_USE_SYSTEM_EXTENSIONS as well. For standalone builds, this should
> not cause any issues, but I haven't tested it.
>
> 3. In src/topology-xml.c, the additional (char *) is to squash a
> compiler warning, since state.tagname is a char *, while "topology" is
> a const char *.
>
> -- Pavan
>