Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: [hwloc-devel] de-c99
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2011-02-18 11:18:30


Brice: I gave you commit access to the bitbucket if you want to just directly push anything else.

I don't know if Samuel has a BB ID, but if this goes back to the SVN trunk soon, the point is moot.

I hard-coded the array initialization:

    https://bitbucket.org/jsquyres/hwloc-de-c99/changeset/782bde127834

I still see a bunch of C99 warnings from the other ports. I can take a whack at these, maybe later today. All I'll be able to do is verify that they compile cleanly; I won't be able to test correctness.

-----
make[3]: Entering directory `/home/jsquyres/hg/hwloc-de-c99/tests/ports'
  CC libhwloc_ports_la-topology.lo
In file included from topology.c:44:0:
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:23:1: warning: function declaration isn’t a prototype
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:27:1: warning: C++ style comments are not allowed in ISO C90
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:27:1: warning: (this will be reported only once per input file)
  CC libhwloc_ports_la-traversal.lo
  CC libhwloc_ports_la-topology-synthetic.lo
  CC libhwloc_ports_la-topology-solaris.lo
In file included from topology-solaris.c:25:0:
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/sys/lgrp_user.h:25:14: warning: comma at end of enumerator list
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/sys/lgrp_user.h:30:23: warning: comma at end of enumerator list
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/sys/lgrp_user.h:40:17: warning: comma at end of enumerator list
topology-solaris.c: In function ‘browse’:
topology-solaris.c:347:5: warning: ISO C90 forbids variable length array ‘cpuids’
topology-solaris.c:378:5: warning: ISO C90 forbids variable length array ‘lgrps’
  CC libhwloc_ports_la-topology-aix.lo
topology-aix.c: In function ‘hwloc_aix_set_thisproc_cpubind’:
topology-aix.c:90:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:90:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_thisproc_cpubind’:
topology-aix.c:97:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:97:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_set_thisthread_cpubind’:
topology-aix.c:104:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:104:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_thisthread_cpubind’:
topology-aix.c:111:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:111:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_set_proc_cpubind’:
topology-aix.c:118:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:118:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_proc_cpubind’:
topology-aix.c:125:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:125:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_set_thisproc_membind’:
topology-aix.c:281:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:281:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_thisproc_membind’:
topology-aix.c:288:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:288:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_set_thisthread_membind’:
topology-aix.c:295:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:295:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_thisthread_membind’:
topology-aix.c:302:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:302:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_set_proc_membind’:
topology-aix.c:309:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:309:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_aix_get_proc_membind’:
topology-aix.c:316:18: warning: ISO C90 forbids specifying subobject to initialize
topology-aix.c:316:3: warning: initializer element is not computable at load time
topology-aix.c: In function ‘hwloc_set_aix_hooks’:
topology-aix.c:563:3: warning: C++ style comments are not allowed in ISO C90
topology-aix.c:563:3: warning: (this will be reported only once per input file)
  CC libhwloc_ports_la-topology-osf.lo
topology-osf.c: In function ‘hwloc_look_osf’:
topology-osf.c:257:7: warning: ISO C90 forbids specifying subobject to initialize
topology-osf.c:258:7: warning: ISO C90 forbids specifying subobject to initialize
topology-osf.c:258:24: warning: ISO C90 forbids specifying subobject to initialize
topology-osf.c:258:7: warning: initializer element is not computable at load time
topology-osf.c:258:7: warning: initializer element is not computable at load time
topology-osf.c:259:7: warning: ISO C90 forbids specifying subobject to initialize
  CC libhwloc_ports_la-topology-windows.lo
In file included from topology-windows.c:17:0:
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:23:1: warning: function declaration isn’t a prototype
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:27:1: warning: C++ style comments are not allowed in ISO C90
/users/jsquyres/hg/hwloc-de-c99/tests/ports/include/windows.h:27:1: warning: (this will be reported only once per input file)
topology-windows.c:157:5: warning: type of bit-field ‘Valid’ is a GCC extension
topology-windows.c:158:5: warning: type of bit-field ‘ShareCount’ is a GCC extension
topology-windows.c:159:5: warning: type of bit-field ‘Win32Protection’ is a GCC extension
topology-windows.c:160:5: warning: type of bit-field ‘Shared’ is a GCC extension
topology-windows.c:161:5: warning: type of bit-field ‘Node’ is a GCC extension
topology-windows.c:162:5: warning: type of bit-field ‘Locked’ is a GCC extension
topology-windows.c:163:5: warning: type of bit-field ‘LargePage’ is a GCC extension
topology-windows.c:164:4: warning: ISO C doesn’t support unnamed structs/unions
topology-windows.c: In function ‘hwloc_win_set_thread_cpubind’:
topology-windows.c:186:3: warning: ISO C90 forbids mixed declarations and code
topology-windows.c: In function ‘hwloc_win_set_proc_cpubind’:
topology-windows.c:229:3: warning: ISO C90 forbids mixed declarations and code
topology-windows.c: In function ‘hwloc_win_get_VirtualAllocExNumaProc’:
topology-windows.c:318:17: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:319:16: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:323:30: warning: assignment from incompatible pointer type
topology-windows.c:328:28: warning: assignment from incompatible pointer type
topology-windows.c: In function ‘hwloc_win_get_QueryWorkingSetExProc’:
topology-windows.c:387:11: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:391:13: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c: In function ‘hwloc_win_get_area_membind’:
topology-windows.c:418:3: warning: ISO C90 forbids mixed declarations and code
topology-windows.c:425:5: warning: ISO C90 forbids variable length array ‘pv’
topology-windows.c: In function ‘hwloc_look_windows’:
topology-windows.c:468:40: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:469:36: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:470:38: warning: ISO C forbids assignment between function pointer and ‘void *’
topology-windows.c:471:42: warning: ISO C forbids assignment between function pointer and ‘void *’
  CC libhwloc_ports_la-topology-darwin.lo
  CC libhwloc_ports_la-topology-freebsd.lo
topology-freebsd.c: In function ‘hwloc_freebsd_set_thread_cpubind’:
topology-freebsd.c:126:3: warning: passing argument 3 of ‘pthread_setaffinity_np’ from incompatible pointer type
/usr/include/pthread.h:445:12: note: expected ‘const struct cpu_set_t *’ but argument is of type ‘cpuset_t *’
topology-freebsd.c: In function ‘hwloc_freebsd_get_thread_cpubind’:
topology-freebsd.c:150:3: warning: passing argument 3 of ‘pthread_getaffinity_np’ from incompatible pointer type
/usr/include/pthread.h:450:12: note: expected ‘struct cpu_set_t *’ but argument is of type ‘cpuset_t *’
  CC libhwloc_ports_la-topology-hpux.lo
  CCLD libhwloc-ports.la
-----

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/