Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] Docs updates
From: Christopher Samuel (samuel_at_[hidden])
Date: 2011-01-06 19:00:30


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/01/11 05:46, Jeff Squyres wrote:
> Please review:
>
> https://svn.open-mpi.org/trac/hwloc/changeset/3046
>

Some possible tweaks:

# Some operating systems do not systematically provide separate
# functions for CPU and Memory binding.

Is "systematically" meant to be there ? I'm not quite
sure what you mean by it in this context, sorry!

# Conversely, some operating systems support the notion of a
# "current" memory binding policy

Can I suggest adding "do" before "support", and..

# and do not permit allocating data on a specific node

change that "and" to a "but".

# without changing the current policy and allocate the data.

Should that "allocate" be "allocating" ?

# Hwloc provides both functions that set the current memory
# binding policies (if supported), and functions that allocate
# memory bound to specific node set.

Can I suggest either dropping "both" or instead saying:

$ Hwloc provides functions that both set the current memory
$ binding policies (if supported) and that allocate memory
$ bound to specific node set.

Hope that's useful!

cheers,
Chris
- --
    Christopher Samuel - Senior Systems Administrator
 VLSCI - Victorian Life Sciences Computation Initiative
 Email: samuel_at_[hidden] Phone: +61 (0)3 903 55545
         http://www.vlsci.unimelb.edu.au/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mV54ACgkQO2KABBYQAh+NegCeMKGa9PEHk92JIaJLNcCkRpWj
loYAn3kUfjpqd/bhIgJ1ppPAf7rgr7k2
=WSgE
-----END PGP SIGNATURE-----