Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: [hwloc-devel] Fwd: [hwloc-svn] svn:hwloc r2868
From: Jiri Hladky (hladky.jiri_at_[hidden])
Date: 2010-12-03 05:31:21


Hi Brice,

I just realized that my messages has been rejected. Sending it again.

Thanks
Jirka

---------- Forwarded message ----------
From: Jiri Hladky <hladky.jiri_at_[hidden]>
Date: Thu, Dec 2, 2010 at 7:30 PM
Subject: Re: [hwloc-devel] [hwloc-svn] svn:hwloc r2868
To: Hardware locality development list <hwloc-devel_at_[hidden]>

Hi Brice,

I have just tested lstopo coming with hwloc-1.1rc4r2880

I'm really glad to see that
--physical is now default for graphical output
type of indexing, hostname, timestamp has been added to the graphical
output.

Just one question regarding timestamp format:
1) It seems that lstopo ignores LC_TIME
2)I would vote to use following format string
date +"%H:%M:%S %a %d %b %Y"
but it might be my personal preference.

I would recommend to replace ctime with strftime function. Please note that
ctime ignores LC_TIME. strftime on the other hand is using LC_TIME

========TEST this C code ==============
#include <stdlib.h>
#include <stdio.h>
#include <time.h>
#include <locale.h>

int main(void) {

char *date;
time_t t;
char date_string[50];
setlocale(LC_TIME, "");

t = time(NULL);
date = ctime(&t);
printf("Date: %s", date);

strftime(date_string,50,"%H:%M:%S %a %d %b %Y",localtime(&t));

printf("Date: %s\n", date_string);

}
========================================
$export LC_ALL=german

$locale
LANG=C
LC_CTYPE="german"
LC_NUMERIC="german"
LC_TIME="german"
LC_COLLATE="german"
LC_MONETARY="german"
LC_MESSAGES="german"
LC_PAPER="german"
LC_NAME="german"
LC_ADDRESS="german"
LC_TELEPHONE="german"
LC_MEASUREMENT="german"
LC_IDENTIFICATION="german"
LC_ALL=german

$./time_test (the program above)
Date: Thu Dec 2 19:28:27 2010
Date: 19:28:27 Do 02 Dez 2010 <--in German

One more question: do you plan to have Ls in the text output? I think it's a
great idea to unify graphical and text output.

Thanks!!
Jirka

On Wed, Dec 1, 2010 at 6:19 PM, Jiri Hladky <hladky.jiri_at_[hidden]>wrote:

> Hi Brice,
>
> it's a good point, I vote to have Ls also in the text output.
>
> Thanks
> Jirka
>
>
> On Wed, Dec 1, 2010 at 8:29 AM, Brice Goglin <Brice.Goglin_at_[hidden]>wrote:
>
>> Le 30/11/2010 15:59, sthibaul_at_[hidden] a écrit :
>> > Author: sthibaul
>> > Date: 2010-11-30 09:59:40 EST (Tue, 30 Nov 2010)
>> > New Revision: 2868
>> > URL: https://svn.open-mpi.org/trac/hwloc/changeset/2868
>> >
>> > Log:
>> > put back L#/P# prefixes in graphical output
>> >
>>
>> Before the release, we'll have to update the graphical outputs in the
>> documentation (and grep for # everywhere too :)).
>>
>> Do we apply something similar to the above patch for the textual output
>> too?
>>
>> Current output: Node #1 (phys=0)
>> Socket #1
>> PU #2 (phys=3)
>>
>> would become: Node L#1 (Phys=0)
>> Socket L#1
>> PU L#2 (Phys=3)
>>
>>
>> Brice
>>
>>
>> _______________________________________________
>> hwloc-devel mailing list
>> hwloc-devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
>>
>
>