Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] hwloc patches for upstream
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2010-11-24 09:59:37


See below.

Sent from my PDA. No type good.

On Nov 24, 2010, at 4:32 AM, "Pavan Balaji" <balaji_at_[hidden]> wrote:

> Folks,
>
> We are maintaining a few patches for hwloc within mpich2. I have just updated to 1.1rc3, and wanted to pass them through you guys to see if (1) these are still relevant, and (2) if they can be merged upstream.
>
> 1. Gracefully abort at configure time if the compiler doesn't support C99: https://trac.mcs.anl.gov/projects/mpich2/changeset/7497/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc
>
> 2. Slight improvement to the error message: https://trac.mcs.anl.gov/projects/mpich2/changeset/7499/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc
>
> 3. Warning squashes from shadowing global variables: https://trac.mcs.anl.gov/projects/mpich2/changeset/7501/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc
>
> The following patches are just a matter of preference. So you might not want to incorporate them, but here they are anyway:
>
> 1. Disable doxygen builds by default: https://trac.mcs.anl.gov/projects/mpich2/changeset/7498/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc

Is there a reason you guys don't configure --disable-embedded-mode?

> 2. Don't automatically pick debugging or picky compiler options unless the user asked for them: https://trac.mcs.anl.gov/projects/mpich2/changeset/7500/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc
>
> Thanks,
>
> -- Pavan
>
> --
> Pavan Balaji
> http://www.mcs.anl.gov/~balaji
> _______________________________________________
> hwloc-devel mailing list
> hwloc-devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel