Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] hwloc patches for upstream
From: Pavan Balaji (balaji_at_[hidden])
Date: 2010-11-24 07:53:14


On 11/24/2010 03:52 AM, Brice Goglin wrote:
>> 3. Warning squashes from shadowing global variables:
>> https://trac.mcs.anl.gov/projects/mpich2/changeset/7501/mpich2/trunk/src/pm/hydra/tools/bind/hwloc/hwloc
>
> Looks ok but I don't see why index/depth would be global variables.
> Aren't they reserved keywords instead?

"depth" was first defined in the parent function (main()), and redefined
within a smaller scope.

"index" was defined in string.h.

  -- Pavan

-- 
Pavan Balaji
http://www.mcs.anl.gov/~balaji