Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] gather-topology.sh and rpm
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2010-11-04 13:19:15


Le 04/11/2010 16:59, Jirka Hladky a écrit :
> 1) Could we remove following line
> abs_top_builddir="/home/jhladky/rpmbuild/BUILD/hwloc-1.2a1r2694"
> during make install ?
>
> It's not used anymore. It's just to make the code look nicer.
>

Done.

> 2) $hwloc-gather-topology.sh /tmp/A/hwloc
> works nicely, too.
>
> However, if I do something nasty like
> $touch /tmp/c
>
> /tmp/c is a regular file
>
> then
>
> $hwloc-gather-topology.sh /tmp/c/hwloc
> mkdir: cannot create directory `/tmp/c': File exists
> mv: accessing `/tmp/c/hwloc.tar.bz2': Not a directory
> Hierarchy gathered in /tmp/c/hwloc.tar.bz2 and kept in
> /tmp/tmp.anx1tIvmak/hwloc/
> ./hwloc-gather-topology.sh: line 75: /tmp/c/hwloc.output: Not a directory
> Expected topology output stored in /tmp/c/hwloc.output
>
> which is nonsense. Neither /tmp/c/hwloc.tar.bz2 nor /tmp/c/hwloc.output
> exists. It can be fixed easily by replacing
>
> mkdir -p "$dirname"
>
> with
>
> if ! mkdir -p "$dirname"
> then
> exit 1
> fi
>

Fixed thanks!

> GOOD NEWS - hwloc will be included in RHEL 6.1 as official (supported) package.
> AMD has asked for it

Great!
.
> Keep up the GREAT work!
>

And keep up the good feedback :)

Brice