Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] [hwloc-svn] svn:hwloc r2223
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2010-06-18 09:56:59


Just curious -- what's the intent of assigning to errno like this? (I ask because I thought that middleware/applications were not supposed to assign to errno)

On Jun 18, 2010, at 12:23 AM, <sthibaul_at_[hidden]> wrote:

> Author: sthibaul
> Date: 2010-06-18 03:23:02 EDT (Fri, 18 Jun 2010)
> New Revision: 2223
> URL: https://svn.open-mpi.org/trac/hwloc/changeset/2223
>
> Log:
> fix error reporting from pthread_getthrds_np
> Text files modified:
> trunk/src/topology-aix.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Modified: trunk/src/topology-aix.c
> ==============================================================================
> --- trunk/src/topology-aix.c (original)
> +++ trunk/src/topology-aix.c 2010-06-18 03:23:02 EDT (Fri, 18 Jun 2010)
> @@ -146,7 +146,7 @@
> {
> struct __pthrdsinfo info;
> int size;
> - if (pthread_getthrds_np(&pthread, PTHRDSINFO_QUERY_TID, &info, sizeof(info), NULL, &size))
> + if ((errno = pthread_getthrds_np(&pthread, PTHRDSINFO_QUERY_TID, &info, sizeof(info), NULL, &size)))
> return -1;
> {
> rsid_t who = { .at_tid = info.__pi_tid };
> _______________________________________________
> hwloc-svn mailing list
> hwloc-svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn
>

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/