Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] want 1.0rc4?
From: Brice Goglin (Brice.Goglin_at_[hidden])
Date: 2010-05-04 01:54:47


On 04/05/2010 03:57, Christopher Samuel wrote:
>
> On 03/05/10 09:57, Jeff Squyres wrote:
>
> > 1.0rc4 is up.
>
> Running coccicheck on 1.0rc4 flags up this construct, I presume
> as an ambiguous construction:
>
> if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) {
>
> That's at line 1518 of src/topology.c in hwloc_discover(). The
> check file simply says:
>
> // !x&y combines boolean negation with bitwise and
>
>
> It's also flagged some unchecked malloc()'s in various bits:
>

Thanks a lot, I think I fixed most of these.

> line 41 of src/misc.c in hwloc_snprintf():
>
> str = malloc(size);
>

I am not sure what to do about this one... Is there any value we could
return without possibly breaking the caller ?

Brice