Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] [hwloc-svn] svn:hwloc r1986
From: Bert Wesarg (bert.wesarg_at_[hidden])
Date: 2010-04-21 08:47:05


On Wed, Apr 21, 2010 at 14:27, <jsquyres_at_[hidden]> wrote:
> Author: jsquyres
> Date: 2010-04-21 08:27:33 EDT (Wed, 21 Apr 2010)
> New Revision: 1986
> URL: https://svn.open-mpi.org/trac/hwloc/changeset/1986
>
> Log:
> Refs #18.  Fix some compiler warnings:
>
>  * Note the change of typeof to !__typeof__ -- I got that from
>   http://gcc.gnu.org/onlinedocs/gcc/Typeof.html.

>From that page:

    If you are writing a header file that must work when included in
ISO C programs, write __typeof__ instead of typeof. See Alternate
Keywords.

> Modified: trunk/src/topology.c
> ==============================================================================
> --- trunk/src/topology.c        (original)
> +++ trunk/src/topology.c        2010-04-21 08:27:33 EDT (Wed, 21 Apr 2010)
> @@ -649,7 +649,7 @@
>  */
>
>  #define merge_index(new, old, field) \
> -  if ((old)->field == (typeof((old)->field)) -1) \
> +  if ((old)->field == (__typeof__((old)->field)) -1) \

That does not look like a header for me.

Bert