Open MPI logo

Hardware Locality Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Hardware Locality Development mailing list

Subject: Re: [hwloc-devel] rc1?
From: Jeff Squyres (jsquyres_at_[hidden])
Date: 2010-04-06 10:57:24


On Apr 6, 2010, at 10:54 AM, Brice Goglin wrote:

> > Is everything else set, ABI-wise?
>
> Just a very minor question: should cpuset_first/last/next/weight return
> unsigned instead of int ? They may return -1 in some corner cases, and
> even more often in the dynamic-cpuset branch. It would be (unsigned) -1
> then, which isn't so bad when we mean "infinite".

My minor preference would be to avoid the cast. But it's a minor preference at best.

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/