On Oct 21, 2009, at 3:43 PM, Brice Goglin wrote:
> Now that I try to implement it, I remember why an inline is
> convenient:
> it doesn't require any build-time/run-time dependency unless you
> really
> use it. If we make this code non-inline, we actually need libibverbs
> at
> build time and runtime. Distro packages will have to depend on
> libibverbs, and we'll get lots of complaints. Same for linux-libnuma.h
> and maybe nvidia cuda one day :) So we'll probably end up splitting
> this
> code out of libhwloc.so and make a libhwloc-openfabrics-verbs.so.
>
Ah, good reason. Let's leave it as inline for 0.9.1, then. But we do
need to fix the topology parameter, sorry. :-(
Should we make a dlopen-like functionality for this kind of stuff for
v1.0? It's not hard to do with libltdl.
--
Jeff Squyres
jsquyres_at_[hidden]
|
![[Flag]](../../../../../community/mirrors/flag-us.gif){kind=small}