On Sep 21, 2009, at 8:44 AM, Samuel Thibault wrote:
> > FWIW, is there a reason we're not using AC_C_RESTRICT in
> > configure.ac? This allows you to use "restrict" in C code
> everywhere;
> > it'll be #defined to something acceptable by the compiler if
> > "restrict" itself is not.
>
> Our __hwloc_restrict macro is actually a copy/paste of AC_C_RESTRICT's
> tinkering.
>
Er... that's a license violation, right? Doesn't that taint hwloc
into making it GPL? (good thing we haven't released yet!)
:-(
> The problem is precisely that AC_C_RESTRICT provides "restrict", and
> not another keyword, so that using it in installed headers may
> conflict
> with other headers' tinkering about restrict. Yes, configure is
> meant to
> detect such kind of things, but it can not know which variety of
> headers
> the user will want to include from its application, and any of them
> could want to define restrict to something else.
>
Would it ever be sane to use one value of restrict in hwloc and a
different value in an upper-level application?
--
Jeff Squyres
jsquyres_at_[hidden]
|