Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r32225 - in trunk: contrib/build-mca-comps-outside-of-tree ompi/contrib/vt/vt ompi/contrib/vt/vt/extlib/otf opal/mca/event/libevent2021/libevent
From: Ralph Castain (rhc_at_[hidden])
Date: 2014-07-12 12:53:23


Okay, let's clarify a couple of things:

1. this wasn't "necessary" in the sense that OMPI won't build without the change. It was "desirable" in terms of eliminating some long-standing warnings coming from those areas due to changes in automake in anticipation of a compatibility break when automake 2.0 is released. In other words, these are "deprecation" warnings.

2. I have advised Matthias and Bert about the situation before, but they were concerned about the proposed change being installed in their code base because of potential backward compatibility issues. However, we are requiring automake 1.12.2 as a minimum level, and this is backward compatible to that level (I checked on the web site, and verified on my machines).

This is why I allowed it into 1.8.2 at this time. It silenced the warnings, and given our minimum AM requirement, was compatible. I wouldn't necessarily advise the VT folks to ingest it as I believe they are trying to stay compatible to older versions of AM (same situation for libevent), but that's up to them.

HTH
Ralph

On Jul 12, 2014, at 9:26 AM, Mike Dubman <miked_at_[hidden]> wrote:

> Yep
>
> On Jul 12, 2014 7:23 PM, "Jeff Squyres (jsquyres)" <jsquyres_at_[hidden]> wrote:
> Mike --
>
> Was this actually necessary in the libevent directory too? What version of "new" automake are you referring to -- 1.14? (I'm not sure I've tried 1.14.x... my cluster version is still at 1.13.x....)
>
>
>
> On Jul 12, 2014, at 8:38 AM, svn-commit-mailer_at_[hidden] wrote:
>
> > Author: miked (Mike Dubman)
> > Date: 2014-07-12 08:38:15 EDT (Sat, 12 Jul 2014)
> > New Revision: 32225
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/32225
> >
> > Log:
> > BUILD: support new automake
> >
> > new automake requires subdirs-object directive, to resolve this:
> >
> > 09:43:37 automake: warning: possible forward-incompatibility.
> > 09:43:37 automake: At least a source file is in a subdirectory, but the 'subdir-objects'
> > 09:43:37 automake: automake option hasn't been enabled. For now, the corresponding output
> > 09:43:37 automake: object file(s) will be placed in the top-level directory. However,
> > 09:43:37 automake: this behaviour will change in future Automake versions: they will
> > 09:43:37 automake: unconditionally cause object files to be placed in the same subdirectory
> > 09:43:37 automake: of the corresponding sources.
> > 09:43:37 automake: You are advised to start using 'subdir-objects' option throughout your
> > 09:43:37 automake: project, to avoid future incompatibilities.
> > 09:43:37 tools/otfmerge/Makefile.common:13: warning: source file '$(OTFMERGESRCDIR)/otfmerge.c' is in a subdirectory,
> > 09:43:37 tools/otfmerge/Makefile.common:13: but option 'subdir-objects' is disabled
> >
> > cmr=v1.8.2:reviewer=ompi-rm1.8
> >
> > Text files modified:
> > trunk/contrib/build-mca-comps-outside-of-tree/configure.ac | 2 +-
> > trunk/ompi/contrib/vt/vt/configure.ac | 2 +-
> > trunk/ompi/contrib/vt/vt/extlib/otf/configure.ac | 2 +-
> > trunk/opal/mca/event/libevent2021/libevent/configure.ac | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > Modified: trunk/contrib/build-mca-comps-outside-of-tree/configure.ac
> > ==============================================================================
> > --- trunk/contrib/build-mca-comps-outside-of-tree/configure.ac Sat Jul 12 08:29:30 2014 (r32224)
> > +++ trunk/contrib/build-mca-comps-outside-of-tree/configure.ac 2014-07-12 08:38:15 EDT (Sat, 12 Jul 2014) (r32225)
> > @@ -25,7 +25,7 @@
> > AC_CONFIG_AUX_DIR(config)
> > AC_CONFIG_MACRO_DIR(config)
> >
> > -AM_INIT_AUTOMAKE([foreign dist-bzip2 no-define 1.11])
> > +AM_INIT_AUTOMAKE([foreign dist-bzip2 no-define 1.11 subdir-objects])
> > AM_SILENT_RULES([yes])
> >
> > AC_LANG([C])
> >
> > Modified: trunk/ompi/contrib/vt/vt/configure.ac
> > ==============================================================================
> > --- trunk/ompi/contrib/vt/vt/configure.ac Sat Jul 12 08:29:30 2014 (r32224)
> > +++ trunk/ompi/contrib/vt/vt/configure.ac 2014-07-12 08:38:15 EDT (Sat, 12 Jul 2014) (r32225)
> > @@ -5,7 +5,7 @@
> > AC_INIT([VampirTrace], [m4_normalize(esyscmd([cat VERSION]))], [vampirsupport_at_[hidden]], [VampirTrace])
> > AC_CONFIG_AUX_DIR(config)
> > AC_CONFIG_MACRO_DIR(config/m4)
> > -AM_INIT_AUTOMAKE([foreign])
> > +AM_INIT_AUTOMAKE([foreign subdir-objects])
> > AC_CONFIG_HEADERS(config.h)
> >
> > # If Automake supports silent rules, enable them.
> >
> > Modified: trunk/ompi/contrib/vt/vt/extlib/otf/configure.ac
> > ==============================================================================
> > --- trunk/ompi/contrib/vt/vt/extlib/otf/configure.ac Sat Jul 12 08:29:30 2014 (r32224)
> > +++ trunk/ompi/contrib/vt/vt/extlib/otf/configure.ac 2014-07-12 08:38:15 EDT (Sat, 12 Jul 2014) (r32225)
> > @@ -8,7 +8,7 @@
> > AC_CONFIG_AUX_DIR(config)
> > AC_CONFIG_MACRO_DIR(config/m4)
> > AC_CANONICAL_SYSTEM
> > -AM_INIT_AUTOMAKE([foreign])
> > +AM_INIT_AUTOMAKE([foreign subdir-objects])
> > AC_CONFIG_HEADERS([config.h])
> >
> > # If Automake supports silent rules, enable them.
> >
> > Modified: trunk/opal/mca/event/libevent2021/libevent/configure.ac
> > ==============================================================================
> > --- trunk/opal/mca/event/libevent2021/libevent/configure.ac Sat Jul 12 08:29:30 2014 (r32224)
> > +++ trunk/opal/mca/event/libevent2021/libevent/configure.ac 2014-07-12 08:38:15 EDT (Sat, 12 Jul 2014) (r32225)
> > @@ -13,7 +13,7 @@
> > AC_CONFIG_MACRO_DIR([m4])
> >
> > # Open MPI: changed to one 1 arg AM INIT_AUTOMAKE
> > -AM_INIT_AUTOMAKE([foreign])
> > +AM_INIT_AUTOMAKE([foreign subdir-objects])
> > # Open MPI: changed AM CONFIG_HEADER to AC CONFIG_HEADERS
> > AC_CONFIG_HEADERS(config.h)
> > AC_DEFINE(NUMERIC_VERSION, 0x02001500, [Numeric representation of the version])
> > _______________________________________________
> > svn-full mailing list
> > svn-full_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>
>
> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: http://www.open-mpi.org/community/lists/devel/2014/07/15122.php
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post: http://www.open-mpi.org/community/lists/devel/2014/07/15123.php