Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] openmpi.spec
From: Mike Dubman (miked_at_[hidden])
Date: 2014-07-12 08:24:58


you are right about setting 'dist %{nil}' will workaround about the src.rpm
filename issue.
but we are using contrib/dist/linux/buildrpm.sh script and not calling
rpmbuild directly.

I don`t mind having %{?dist} in the spec file, as long as this change is
backwards compatible:

You can change buildrpm.sh +215 to include --define 'dist %{nil}' when
creating src.rpm and it will be fine for all.

On Sat, Jul 12, 2014 at 11:05 AM, <olivier.lahaye1_at_[hidden]> wrote:

>
> This is a bad idea to remove the %{?dist} IMHO.
>
> To generate a generic src.rpm, you should use the following command:
>
> rpmbuild -ts tarball --define 'dist %{nil}'
> or
> rpmbuild -bs openmpi.spec --define 'dist %{nil}'
>
> This can be put in the main Maikefile:
>
> srpm: tarball_bz2
> rpmbuild -ts openmpi-$(VERSION).tar.bz2 --define 'dist %{nil}'
>
>
> And you should keep the %{?dist} is the release tag so when built, the rpm
> is clearly identified for a specific distro.
>
> My 2 cents.
>
> Best regards,
>
> PS: By the way, %{?dist} is not the arch, it's the distro tag.
> AFAIK, the values for main distros I know are:
> rhel6 => .el6
> rhel7 => .el6
> centos6 => .el6
> centos7 => .el7.centos
> fedora-# => .fc#
> Mandriva => .mdvYYYY.r when YYYY.r is the release such as 2013.1
> Mageia => ?
>
> Olivier.
>
> ----- Mail original -----
> > De: "Jeff Squyres (jsquyres)" <jsquyres_at_[hidden]>
> > À: "Open MPI Developers List" <devel_at_[hidden]>
> > Envoyé: Jeudi 10 Juillet 2014 22:27:12
> > Objet: Re: [OMPI devel] openmpi.spec
> >
> > Mike and I talked in IM. The results of our chat was Mike's commit:
> >
> > https://svn.open-mpi.org/trac/ompi/changeset/32205
> >
> >
> > On Jul 10, 2014, at 9:57 AM, Mike Dubman <miked_at_[hidden]>
> > wrote:
> >
> > >
> > > Hi,
> > > The following commit
> > > https://svn.open-mpi.org/trac/ompi/changeset/32147 does some harm:
> > >
> > > the line 202 in the change causes openmpi.src.rpm to contain arch
> > > in the rpm name, i.e. openmpi-1.8.2a1-1.el6.src.rpm
> > >
> > > The src.rpm should be arch agnostic.
> > >
> > > what do you think?
> > >
> > > Thanks
> > > _______________________________________________
> > > devel mailing list
> > > devel_at_[hidden]
> > > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > > Link to this post:
> > > http://www.open-mpi.org/community/lists/devel/2014/07/15097.php
> >
> >
> > --
> > Jeff Squyres
> > jsquyres_at_[hidden]
> > For corporate legal information go to:
> > http://www.cisco.com/web/about/doing_business/legal/cri/
> >
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > Link to this post:
> > http://www.open-mpi.org/community/lists/devel/2014/07/15103.php
> >
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/07/15114.php