Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [PATCH] Fix typo defining macro _WORD_MASK_
From: Ralph Castain (rhc_at_[hidden])
Date: 2014-05-02 13:21:39


Fixed in r31615

On Feb 18, 2014, at 7:55 AM, Nathan Hjelm <hjelmn_at_[hidden]> wrote:

> _WORD_MASK_ violates C99 § 7.1.3:
>
> "All identifiers that begin with an underscore and either an uppercase letter or another
> underscore are always reserved for any use."
>
>
> So we should probably rename the identifier.
>
> -Nathan
>
> On Mon, Feb 17, 2014 at 04:37:34PM +0000, Jeff Squyres (jsquyres) wrote:
>> +1
>>
>> On Feb 16, 2014, at 4:55 PM, Andreas Schwab <schwab_at_[hidden]> wrote:
>>
>>> diff --git a/opal/util/crc.c b/opal/util/crc.c
>>> index 9cfae94..c2112de 100644
>>> --- a/opal/util/crc.c
>>> +++ b/opal/util/crc.c
>>> @@ -41,7 +41,7 @@
>>> #elif (OPAL_ALIGNMENT_LONG == 4)
>>> #define _WORD_MASK_ 0x3
>>> #else
>>> -#define _WORD_MASK 0xFFFF
>>> +#define _WORD_MASK_ 0xFFFF
>>> #endif
>>>
>>>
>>> --
>>> 1.9.0
>>>
>>> --
>>> Andreas Schwab, schwab_at_[hidden]
>>> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
>>> "And now for something completely different."
>>> _______________________________________________
>>> devel mailing list
>>> devel_at_[hidden]
>>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>>
>>
>> --
>> Jeff Squyres
>> jsquyres_at_[hidden]
>> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
>>
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel