Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r31369 - trunk/ompi/include
From: Tim Mattox (tmattox_at_[hidden])
Date: 2014-04-11 11:43:18


Ah, that makes much more sense. I'll return to my ompi-svn-lurker mode
now. :-)

On Fri, Apr 11, 2014 at 11:37 AM, Jeff Squyres (jsquyres) <
jsquyres_at_[hidden]> wrote:

> Note that it's mpif.h.in, not mpif.h. It gets filled in via
> configure/AC_DEFINE. On the trunk, for example, it's replaced by:
>
> /* Enable warnings in wrong usage (e.g. deprecated) in user-level code */
> #ifndef OMPI_WANT_MPI_INTERFACE_WARNING
> #define OMPI_WANT_MPI_INTERFACE_WARNING 1
> #endif
>
>
> On Apr 11, 2014, at 11:26 AM, Tim Mattox <tmattox_at_[hidden]> wrote:
>
> > This #ifndef sequence below the comment doesn't look right...
> > "if BLAH is NOT defined, undefine BLAH" ????
> > That doesn't accomplish anything as far as I can tell.
> >
> > On Fri, Apr 11, 2014 at 11:17 AM, <svn-commit-mailer_at_[hidden]>
> wrote:
> > Author: jsquyres (Jeff Squyres)
> > Date: 2014-04-11 11:17:48 EDT (Fri, 11 Apr 2014)
> > New Revision: 31369
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/31369
> >
> > Log:
> > mpi.h.in: We're long past the v1.5 series; this comment can go away
> >
> > Text files modified:
> > trunk/ompi/include/mpi.h.in | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > Modified: trunk/ompi/include/mpi.h.in
> >
> ==============================================================================
> > --- trunk/ompi/include/mpi.h.in Fri Apr 11 00:16:28 2014 (r31368)
> > +++ trunk/ompi/include/mpi.h.in 2014-04-11 11:17:48 EDT (Fri, 11 Apr
> 2014) (r31369)
> > @@ -168,8 +168,6 @@
> > #undef OMPI_PARAM_CHECK
> >
> > /* Enable warnings in wrong usage (e.g. deprecated) in user-level code
> */
> > -/* XXX This __disabled__ by default for Open MPI-1.5, but will be
> __enabled__ for Open MPI-1.7 by default */
> > -/* Users should be notified about this proposed change. */
> > #ifndef OMPI_WANT_MPI_INTERFACE_WARNING
> > #undef OMPI_WANT_MPI_INTERFACE_WARNING
> > #endif
> > _______________________________________________
> > svn-full mailing list
> > svn-full_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
> >
> >
> >
> > --
> > Tim Mattox, Ph.D. - tmattox_at_[hidden]
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> > Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/04/14492.php
>
>
> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to:
> http://www.cisco.com/web/about/doing_business/legal/cri/
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/04/14493.php
>

-- 
Tim Mattox, Ph.D. - tmattox_at_[hidden]