Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: [OMPI devel] common_verbs fix
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2014-03-25 11:01:27


Mike / Vasily / Alina --

Are you guys using ompi_common_verbs_find_ports() somewhere? I don't see it being used anyhere other than the usnnic btl.

I ask because I was planning to consolidate this part of common verbs up into the usnic BTL in the not-distant future because no one else was using it.

But if you're actually using it somewhere, I won't do that...

Begin forwarded message:

> From: <svn-commit-mailer_at_[hidden]>
> Subject: [OMPI svn-full] svn:open-mpi r31200 - trunk/ompi/mca/common/verbs
> Date: March 25, 2014 10:41:09 AM EDT
> To: <svn-full_at_[hidden]>
> Reply-To: <devel_at_[hidden]>
>
> Author: alinas (Alina Sklarevich)
> Date: 2014-03-25 10:41:09 EDT (Tue, 25 Mar 2014)
> New Revision: 31200
> URL: https://svn.open-mpi.org/trac/ompi/changeset/31200
>
> Log:
> common/verbs: added a call to ompi_ibv_free_device_list.
>
> the ompi_common_verbs_find_ports function had a call to
> ompi_ibv_get_device_list, but not to ompi_ibv_free_device_list.
>
> fixed by Alina, reviewed by Vasily/Mike.
> cmr=v1.8:reviewer=ompi-rm1.8
>
> Text files modified:
> trunk/ompi/mca/common/verbs/common_verbs_find_ports.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Modified: trunk/ompi/mca/common/verbs/common_verbs_find_ports.c
> ==============================================================================
> --- trunk/ompi/mca/common/verbs/common_verbs_find_ports.c Tue Mar 25 10:27:09 2014 (r31199)
> +++ trunk/ompi/mca/common/verbs/common_verbs_find_ports.c 2014-03-25 10:41:09 EDT (Tue, 25 Mar 2014) (r31200)
> @@ -638,6 +638,7 @@
> }
>
> /* All done! */
> + ompi_ibv_free_device_list(devices);
> return port_list;
>
> err_free_port_list:
> @@ -646,6 +647,7 @@
> item = opal_list_remove_first(port_list)) {
> OBJ_RELEASE(item);
> }
> + ompi_ibv_free_device_list(devices);
>
> err_free_argv:
> if (NULL != if_sanity_list) {
> _______________________________________________
> svn-full mailing list
> svn-full_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/