Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] [OMPI svn] svn:open-mpi r31005 - trunk/ompi/mca/bcol/basesmuma
From: Dave Goodell (dgoodell) (dgoodell_at_[hidden])
Date: 2014-03-11 18:06:46


Might want to replace the bzero with memset while you're at it. I recall hitting portability problems on weird systems and Linux systems where features.h has been poked the wrong way with "_POSIX_SOURCE" and friends.

-Dave

On Mar 11, 2014, at 4:59 PM, svn-commit-mailer_at_[hidden] wrote:

> Author: rhc (Ralph Castain)
> Date: 2014-03-11 17:59:17 EDT (Tue, 11 Mar 2014)
> New Revision: 31005
> URL: https://svn.open-mpi.org/trac/ompi/changeset/31005
>
> Log:
> Silence warning
>
> cmr=v1.8:reviewer=hjelmn
>
> Text files modified:
> trunk/ompi/mca/bcol/basesmuma/bcol_basesmuma_module.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Modified: trunk/ompi/mca/bcol/basesmuma/bcol_basesmuma_module.c
> ==============================================================================
> --- trunk/ompi/mca/bcol/basesmuma/bcol_basesmuma_module.c Tue Mar 11 17:42:42 2014 (r31004)
> +++ trunk/ompi/mca/bcol/basesmuma/bcol_basesmuma_module.c 2014-03-11 17:59:17 EDT (Tue, 11 Mar 2014) (r31005)
> @@ -85,7 +85,7 @@
> mca_bcol_basesmuma_module_construct(mca_bcol_basesmuma_module_t *module)
> {
> /* initialize all values to 0 */
> - bzero ((uintptr_t) module + sizeof (module->super), sizeof (*module) - sizeof (module->super));
> + bzero ((void*)((uintptr_t) module + sizeof (module->super)), sizeof (*module) - sizeof (module->super));
> module->super.bcol_component = (mca_bcol_base_component_t *) &mca_bcol_basesmuma_component;
> module->super.list_n_connected = NULL;
> module->super.hier_scather_offset = 0;
> _______________________________________________
> svn mailing list
> svn_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/svn