Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] Bad parameter in file oob_tcp.c
From: Ralph Castain (rhc_at_[hidden])
Date: 2014-03-05 17:35:19


Cool - I'll make the correction. Thx!

On Wed, Mar 5, 2014 at 2:08 PM, George Bosilca <bosilca_at_[hidden]> wrote:

> I'm afraid the snippet pointed by Ralph is incorrect, as INADDR_ANY should
> not be a valid return for inet_addr. Here is a quick check on different
> OSes.
>
> On Linux, the man Page states:
>
> If the input is invalid, INADDR_NONE (usually -1) is returned.
>
>
> On Mac OS X:
>
> The constant INADDR_NONE is returned by inet_addr() and inet_network() for
> malformed requests.
>
>
> On Windows things are slightly more complicated:
>
> On Windows Server 2003 and later if the string in the cp parameter is an
> empty string, then inet_addr returns the value INADDR_NONE. If NULL is
> passed in the cp parameter, then inet_addrreturns the value INADDR_NONE.
> On Windows XP and earlier if the string in the cp parameter is an empty
> string, then inet_addr returns the value INADDR_ANY. If NULL is passed in
> the cp parameter, then inet_addr returns the value INADDR_NONE.
>
>
> Thus, we should compare with INADDR_NONE and not with INADDR_ANY.
>
> George.
>
> On Mar 4, 2014, at 22:06 , Ralph Castain <rhc_at_[hidden]> wrote:
>
> The code generating the error is here:
>
> in->sin_addr.s_addr = inet_addr(host);
> if (in->sin_addr.s_addr == INADDR_ANY) {
> return ORTE_ERR_BAD_PARAM;
> }
>
>
> The address is resolving to INADDR_ANY instead of a regular address. Does
> cygwin require some other method for resolving a hostname to an IP address?
>
> Ralph
>
>
>
> On Tue, Mar 4, 2014 at 3:19 PM, Marco Atzeri <marco.atzeri_at_[hidden]>wrote:
>
>> noted on cygwin with 1.7.4 and on 1.7.5rc1
>>
>> $ mpirun -n 4 ./hello_c.exe
>> [MATZERI:06212] [[62628,1],0] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:05620] [[62628,1],1] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:06892] [[62628,1],2] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> [MATZERI:03908] [[62628,1],3] ORTE_ERROR_LOG: Bad parameter in file
>> /pub/devel/openmpi/openmpi-1.7.5rc1-1/src/openmpi-1.7.5rc1/orte/mca/oob/tcp/oob_tcp.c
>> at line 292
>> Hello, world, I am 1 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco_at_MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 2 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco_at_MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 3 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco_at_MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>> Hello, world, I am 0 of 4, (Open MPI v1.7.5rc1, package: Open MPI
>> marco_at_MATZERI Distribution, ident: 1.7.5rc1, Mar 01, 2014, 102)
>>
>> any idea what could be the cause ?
>>
>> I don't remember it in previous 1.7.x releases
>>
>> the relevant code is:
>>
>> if ((rc = parse_uri(pop->af_family, pop->net, pop->port, (struct
>> sockaddr*) &inaddr)) != ORTE_SUCCESS) {
>> ORTE_ERROR_LOG(rc);
>>
>> Regards
>> Marco
>> _______________________________________________
>> devel mailing list
>> devel_at_[hidden]
>> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
>> Searchable archives: http://www.open-mpi.org/
>> community/lists/devel/2014/03/index.php
>>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Searchable archives:
> http://www.open-mpi.org/community/lists/devel/2014/03/index.php
>
>
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
> Link to this post:
> http://www.open-mpi.org/community/lists/devel/2014/03/14301.php
>