Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |  

This web mail archive is frozen.

This page is part of a frozen web archive of this mailing list.

You can still navigate around this archive, but know that no new mails have been added to it since July of 2016.

Click here to be taken to the new web archives of this list; it includes all the mails that are in this frozen archive plus all new mails that have been sent to the list since it was migrated to the new archives.

Subject: Re: [OMPI devel] [OMPI svn-full] svn:open-mpi r30906 - in trunk: . config
From: Jeff Squyres (jsquyres) (jsquyres_at_[hidden])
Date: 2014-03-03 10:29:20


More specifically, this goes back to the original question I asked long ago: if it is time to unify the fortran language CLI options (i.e., --disable-fortran instead of/in addition to --disable-mpi-fortran / --disable-oshmem-fortran).

I say this because by the logic from #1 below, if you have to --disable-mpi-fortran --disable-oshmem-fortran, that seems somewhat annoying.

...but then again, that might not even be right. This requires someone to really re-think the options and come up with a good solution; what I said above is a gut reaction, and I haven't thought through the corner cases.

Regardless, for 1.7.x, my $0.02 is that the --disable-mpi-fortran switch should also disable OSHMEM Fortran bindings (unless --enable-oshmem-fortran was specified, in which case that would be an error). Something Better can be done for trunk/v1.9.

On Mar 3, 2014, at 7:13 AM, "Jeff Squyres (jsquyres)" <jsquyres_at_[hidden]> wrote:

> This commit breaks building without MPI Fortran support. Note that I did *NOT* specify --enable-oshmem-fortran:
>
> -----
> *** OSHMEM Configuration options
> checking if want SGI/Quadrix compatibility mode... yes
> checking if want OSHMEM API parameter checking... always
> checking if want pshmem_... yes
> checking if want to build OSHMEM fortran bindings... bad value OMPI_WANT_FORTRAN_BINDINGS: (0)
> configure: WARNING: Your request to --enable-oshmem-fortran can only be satisfied if fortran support is enabled in OMPI.
> You see this message for one of two reasons:
> 1. OMPI fortran support has been explicitly disabled via --disable-mpi-fortran and OSHMEM fortran support was implicitly enabled by default.
> 2. OMPI fortran support has been explicitly disabled via --disable-mpi-fortran and OSHMEM fortran support was explicitly enabled with --enable-oshmem-fortran.
> Configure will abort because you, a human, have asked for something that cannot be provided.
> configure: error: Cannot continue
> -----
>
> On Mar 3, 2014, at 1:58 AM, <svn-commit-mailer_at_[hidden]> wrote:
>
>> Author: miked (Mike Dubman)
>> Date: 2014-03-03 04:58:11 EST (Mon, 03 Mar 2014)
>> New Revision: 30906
>> URL: https://svn.open-mpi.org/trac/ompi/changeset/30906
>>
>> Log:
>> OSHMEM: fix fortran binding
>>
>> based on true story: http://www.open-mpi.org/community/lists/devel/2014/03/14262.php
>>
>> fixed by Roman, reviewed by Igor/Mike
>>
>> cmr=v1.7.5:reviewer=ompi-rm1.7
>>
>> Text files modified:
>> trunk/config/oshmem_configure_options.m4 | 2 +-
>> trunk/configure.ac | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Modified: trunk/config/oshmem_configure_options.m4
>> ==============================================================================
>> --- trunk/config/oshmem_configure_options.m4 Mon Mar 3 01:41:46 2014 (r30905)
>> +++ trunk/config/oshmem_configure_options.m4 2014-03-03 04:58:11 EST (Mon, 03 Mar 2014) (r30906)
>> @@ -93,7 +93,7 @@
>> AC_ARG_ENABLE(oshmem-fortran,
>> AC_HELP_STRING([--enable-oshmem-fortran],
>> [enable OSHMEM Fortran bindings (default: enabled if Fortran compiler found)]))
>> -if test "$enable_oshmem_fortran" != "no" -a "$ompi_fortran_happy" = 1; then
>> +if test "$enable_oshmem_fortran" != "no"; then
>> # If no OMPI FORTRAN, bail
>> AS_IF([test $OMPI_WANT_FORTRAN_BINDINGS -eq 0 -a "$enable_oshmem" != "no"],
>> [AC_MSG_RESULT([bad value OMPI_WANT_FORTRAN_BINDINGS: ($OMPI_WANT_FORTRAN_BINDINGS)])
>>
>> Modified: trunk/configure.ac
>> ==============================================================================
>> --- trunk/configure.ac Mon Mar 3 01:41:46 2014 (r30905)
>> +++ trunk/configure.ac 2014-03-03 04:58:11 EST (Mon, 03 Mar 2014) (r30906)
>> @@ -605,7 +605,7 @@
>> AM_CONDITIONAL(OSHMEM_BUILD_FORTRAN_BINDINGS,
>> [test "$ompi_fortran_happy" == "1" -a \
>> "$OMPI_WANT_FORTRAN_BINDINGS" == "1" -a \
>> - "$oshmem_fortran_enable" != "no"])
>> + "$enable_oshmem_fortran" != "no"])
>>
>> # checkpoint results
>> AC_CACHE_SAVE
>> _______________________________________________
>> svn-full mailing list
>> svn-full_at_[hidden]
>> http://www.open-mpi.org/mailman/listinfo.cgi/svn-full
>
>
> --
> Jeff Squyres
> jsquyres_at_[hidden]
> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

-- 
Jeff Squyres
jsquyres_at_[hidden]
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/