Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] startup sstore orte/mca/ess/base/ess_base_std_tool.c
From: Josh Hursey (jjhursey_at_[hidden])
Date: 2014-02-21 15:07:49


+1

On Fri, Feb 21, 2014 at 10:04 AM, Ralph Castain <rhc_at_[hidden]> wrote:

> looks fine to me
>
>
> On Feb 21, 2014, at 6:23 AM, Adrian Reber <adrian_at_[hidden]> wrote:
>
> > To restart a process using orte-restart I need sstore initialized when
> > running as a tool. This is currently missing. The new code is
> >
> > #if OPAL_ENABLE_FT_CR == 1
> >
> > and should only affect --with-ft builds. The following is the change I
> > want to make:
> >
> > diff --git a/orte/mca/ess/base/ess_base_std_tool.c
> b/orte/mca/ess/base/ess_base_std_tool.c
> > index 93aed89..b102e6d 100644
> > --- a/orte/mca/ess/base/ess_base_std_tool.c
> > +++ b/orte/mca/ess/base/ess_base_std_tool.c
> > @@ -43,6 +43,7 @@
> > #include "orte/mca/state/base/base.h"
> > #if OPAL_ENABLE_FT_CR == 1
> > #include "orte/mca/snapc/base/base.h"
> > +#include "orte/mca/sstore/base/base.h"
> > #endif
> > #include "orte/util/proc_info.h"
> > #include "orte/util/session_dir.h"
> > @@ -175,11 +176,22 @@ int orte_ess_base_tool_setup(void)
> > error = "orte_snapc_base_open";
> > goto error;
> > }
> > + if (ORTE_SUCCESS != (ret =
> mca_base_framework_open(&orte_sstore_base_framework, 0))) {
> > + ORTE_ERROR_LOG(ret);
> > + error = "orte_sstore_base_open";
> > + goto error;
> > + }
> > +
> > if (ORTE_SUCCESS != (ret = orte_snapc_base_select(ORTE_PROC_IS_HNP,
> ORTE_PROC_IS_APP))) {
> > ORTE_ERROR_LOG(ret);
> > error = "orte_snapc_base_select";
> > goto error;
> > }
> > + if (ORTE_SUCCESS != (ret = orte_sstore_base_select())) {
> > + ORTE_ERROR_LOG(ret);
> > + error = "orte_sstore_base_select";
> > + goto error;
> > + }
> >
> > /* Tools do not need all the OPAL CR stuff */
> > opal_cr_set_enabled(false);
> > @@ -201,6 +213,7 @@ int orte_ess_base_tool_finalize(void)
> >
> > #if OPAL_ENABLE_FT_CR == 1
> > mca_base_framework_close(&orte_snapc_base_framework);
> > + mca_base_framework_close(&orte_sstore_base_framework);
> > #endif
> >
> > /* if I am a tool, then all I will have done is
> >
> >
> > Adrian
> > _______________________________________________
> > devel mailing list
> > devel_at_[hidden]
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> _______________________________________________
> devel mailing list
> devel_at_[hidden]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

-- 
Joshua Hursey
Assistant Professor of Computer Science
University of Wisconsin-La Crosse
http://cs.uwlax.edu/~jjhursey