Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: Re: [OMPI devel] mca_base_component_distill_checkpoint_ready variable
From: Nathan Hjelm (hjelmn_at_[hidden])
Date: 2014-02-21 12:12:54


On Fri, Feb 21, 2014 at 05:21:10PM +0100, Adrian Reber wrote:
> There is a variable in the FT code which is not defined and therefore
> currently #ifdef'd out.
>
> #if (OPAL_ENABLE_FT == 1) && (OPAL_ENABLE_FT_CR == 1)
> #ifdef ENABLE_FT_FIXED
> /* FIXME_FT
> *
> * the variable mca_base_component_distill_checkpoint_ready
> * was removed by commit 8181c8273c486bba59b3dead324939eac1a58b8c (r28237)
> * "Introduce the MCA framework system. This formalizes the interface frameworks must provide."
> *
> * */
> if (mca_base_component_distill_checkpoint_ready) {
> open_only_flags |= MCA_BASE_METADATA_PARAM_CHECKPOINT;
> }
> #endif /* ENABLE_FT_FIXED */
> #endif /* (OPAL_ENABLE_FT == 1) && (OPAL_ENABLE_FT_CR == 1) */
>
>
> The variable 'mca_base_component_distill_checkpoint_ready' used to exist but was removed
> with commit 'r28237':
>
> -#if (OPAL_ENABLE_FT == 1) && (OPAL_ENABLE_FT_CR == 1)
> - {
> - int param_id = -1;
> - int param_val = 0;
> - /*
> - * Extract supported mca parameters for selection contraints
> - * Supported Options:
> - * - mca_base_component_distill_checkpoint_ready = Checkpoint Ready
> - */
> - param_id = mca_base_param_reg_int_name("mca", "base_component_distill_checkpoint_ready",
> - "Distill only those components that are Checkpoint Ready",
> - false, false,
> - 0, &param_val);
> - if( 0 != param_val ) { /* Select Checkpoint Ready */
> - open_only_flags |= MCA_BASE_METADATA_PARAM_CHECKPOINT;
> - }
> - }
> -#endif /* (OPAL_ENABLE_FT == 1) && (OPAL_ENABLE_FT_CR == 1) */
>
> The variable is defined in contrib/amca-param-sets/ft-enable-cr
>
> mca_base_component_distill_checkpoint_ready=1
>
> Looking at the name of other variable I would say it should be called
>
> opal_base_distill_checkpoint_ready
>
> and probably created with mca_base_var_register() or mca_base_component_var_register().
>
> What would be the best place to create the variable so that it can be used again in
> the FT code?

Some variables are registered in opal/runtime/opal_params.c. That might
be a good place to add it.

-Nathan



  • application/pgp-signature attachment: stored