Open MPI logo

Open MPI Development Mailing List Archives

  |   Home   |   Support   |   FAQ   |   all Development mailing list

Subject: [OMPI devel] Don't try to call orte_show_help() before orte_init() succeeds
From: René Oertel (rene.oertel_at_[hidden])
Date: 2014-01-31 09:49:35


Dear OpenMPI developers,

I think the source code modification titled
"Ensure that we don't try to call orte_show_help() before orte_init()
succeeds." is buggy (see [1] at lines 755-763).
There is no difference between the if and the else path of the code,
i.e. checking orte_setup/rte_setup makes no sense.
You will find the erroneous code below the 'error' label in
ompi/runtime/ompi_mpi_init.c in SVN trunk, too.

Kind regards,

René

[1]
https://github.com/open-mpi/ompi-svn-mirror/commit/b200ea0e1554d40ed4948f9823fc6dd7b0cc3ba6#diff-3673b21a7f42dc0665ea4470b3171df1